From owner-p4-projects@FreeBSD.ORG Mon Apr 3 19:31:09 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id AB34216A423; Mon, 3 Apr 2006 19:31:09 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 825CA16A400 for ; Mon, 3 Apr 2006 19:31:09 +0000 (UTC) (envelope-from imp@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E42E43D48 for ; Mon, 3 Apr 2006 19:31:09 +0000 (GMT) (envelope-from imp@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k33JV9He041994 for ; Mon, 3 Apr 2006 19:31:09 GMT (envelope-from imp@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k33JV8X6041991 for perforce@freebsd.org; Mon, 3 Apr 2006 19:31:08 GMT (envelope-from imp@freebsd.org) Date: Mon, 3 Apr 2006 19:31:08 GMT Message-Id: <200604031931.k33JV8X6041991@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to imp@freebsd.org using -f From: Warner Losh To: Perforce Change Reviews Cc: Subject: PERFORCE change 94551 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2006 19:31:09 -0000 http://perforce.freebsd.org/chv.cgi?CH=94551 Change 94551 by imp@imp_Speedy on 2006/04/03 19:30:42 Need callback, I think, for request/release bus. If not for this, then for the specialized iicbus bridges that we're going to use in our design. Affected files ... .. //depot/projects/arm/src/sys/arm/at91/at91_twi.c#9 edit Differences ... ==== //depot/projects/arm/src/sys/arm/at91/at91_twi.c#9 (text+ko) ==== @@ -42,6 +42,8 @@ #include #include +#include +#include #include "iicbus_if.h" struct at91_twi_softc @@ -455,6 +457,25 @@ return EIO; } +static int +at91_twi_callback(device_t dev, int index, caddr_t *data) +{ + int error = 0; + + switch (index) { + case IIC_REQUEST_BUS: + break; + + case IIC_RELEASE_BUS: + break; + + default: + error = EINVAL; + } + + return (error); +} + static device_method_t at91_twi_methods[] = { /* Device interface */ DEVMETHOD(device_probe, at91_twi_probe), @@ -462,7 +483,7 @@ DEVMETHOD(device_detach, at91_twi_detach), /* iicbus interface */ -// DEVMETHOD(iicbus_callback, iicbus_null_callback), + DEVMETHOD(iicbus_callback, at91_twi_callback), DEVMETHOD(iicbus_repeated_start, at91_twi_repeated_start), DEVMETHOD(iicbus_start, at91_twi_start), DEVMETHOD(iicbus_stop, at91_twi_stop),