From owner-cvs-all@FreeBSD.ORG  Sun Dec  5 22:16:47 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1AA1A16A4EB; Sun,  5 Dec 2004 22:16:47 +0000 (GMT)
Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A028E43D5D; Sun,  5 Dec 2004 22:16:46 +0000 (GMT)
	(envelope-from nate@root.org)
Received: from [10.0.5.50] (adsl-64-171-184-243.dsl.snfc21.pacbell.net
	[64.171.184.243])
	by www.cryptography.com (8.12.8/8.12.8) with ESMTP id iB5MGcC4009689
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Sun, 5 Dec 2004 14:16:39 -0800
Message-ID: <41B388C6.5090409@root.org>
Date: Sun, 05 Dec 2004 14:16:38 -0800
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 0.9 (Windows/20041103)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: "M. Warner Losh" <imp@bsdimp.com>
References: <200412050135.iB51ZJJl040909@repoman.freebsd.org>
	<20041204.221541.115654786.imp@bsdimp.com>
In-Reply-To: <20041204.221541.115654786.imp@bsdimp.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/dev/acpica acpi.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Dec 2004 22:16:47 -0000

M. Warner Losh wrote:
> In message: <200412050135.iB51ZJJl040909@repoman.freebsd.org>
>             Nate Lawson <njl@FreeBSD.org> writes:
> :   If we are resuming non-MPSAFE drivers, they need Giant held for them.
> 
> Generally, when walking the device tree, one must have Giant.  I've
> been meaning to add asserts for this in the tree...  I think that we
> have enough things giant is pushed out of that it is time...

I'd like that.  I think the GIANT_REQUIRED asserts should go in the 
root_bus suspend/resume/shutdown methods, not in acpi.  This will cover 
everyone unless a driver drops Giant and doesn't reacquire it (unlikely).


-- 
Nate