From owner-freebsd-ports@FreeBSD.ORG Tue Jul 31 16:20:19 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6354E1065678 for ; Tue, 31 Jul 2012 16:20:19 +0000 (UTC) (envelope-from itechbear@gmail.com) Received: from mail-gg0-f182.google.com (mail-gg0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3E21C8FC14 for ; Tue, 31 Jul 2012 16:20:13 +0000 (UTC) Received: by ggnm2 with SMTP id m2so7274365ggn.13 for ; Tue, 31 Jul 2012 09:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=aGrJiIEFCFtxgZNg/WGFv1PquagXsiHgz5ZsO5VGh+k=; b=JB68dQyunVqrEDzZsdcoi+U8ra+NRk92xwCDqnCOtSNXpqdgKy0ldYcTaPk1BXp6WC FT0MQo46ktlTM3RULQNLPEfksT+d9s1uzL7j/bvuQqkDZbeHEoxzYN3p04c3iIGl5fQb vIu/ms/7ip94MG+/I+1j3oqCSI3qsdmBSmFZYd1NlprIiAidCOCCxgtndOYOdLB6VtiN yCZ6OmJLvofShKQT6U9A4sR/UNlbauvlh9saAUBPxljCLxf9o+s7MaMnCgxVPR8qgxaa Nj7XVTquwaQeojrOB0k76HJU92UAjDj9DJMPVbOi6HfV5kc2aXkJOpl011qo9i6GKRM9 ks7w== MIME-Version: 1.0 Received: by 10.60.29.230 with SMTP id n6mr24048366oeh.22.1343751612671; Tue, 31 Jul 2012 09:20:12 -0700 (PDT) Received: by 10.76.10.41 with HTTP; Tue, 31 Jul 2012 09:20:12 -0700 (PDT) In-Reply-To: <2468689.1qABUSPjkn@mocha.verizon.net> References: <10338955.6OcLDV9eam@mocha.verizon.net> <2468689.1qABUSPjkn@mocha.verizon.net> Date: Wed, 1 Aug 2012 00:20:12 +0800 Message-ID: From: HU Dong To: "Jason E. Hale" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Michael Scheidell , freebsd-ports@freebsd.org Subject: Re: Problems about making a new port X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2012 16:20:19 -0000 On Tue, Jul 31, 2012 at 11:27 PM, Jason E. Hale wrote: > On Tuesday, July 31, 2012 10:10:48 HU Dong wrote: > > > As for "/usr/local/share/certs/ca-root-nss.crt", it's a cert file > installed > > by security/ca_root_nss. I can't figure out how to determine its > > location automatically, but I think ${PREFIX} is not proper either, so I > > replace /usr/local with ${LOCALBASE}. > > > I've looked over this port a lot closer and it doesn't seem like this > replacement is really necessary. The user can define the location of the > cert > in ~/.xombrero.conf with the ssl_ca_file variable. > > > Now it seems that the only problem left is to create a wrapper script for > > the binary. I don't know where to find tutorials. Is there a google > example > > that I can refer to? Roughly, I need to know where to place the original > > binary, how to name the wrapper, whether there's anything additional to > do > > except copying files and executing the original binary, etc. > > > I'm not sure this is the right thing now since I looked at that script and > it > requires www/get_flash_videos and multimedia/mplayer. You could make them > optional dependencies, but I wouldn't install the script to the users home > directory unless get_flash_videos and mplayer are installed. It might be > better to leave it up to the user since they will have to manually install > .xombrero.conf anyways. Maybe a pkg-message would be more appropriate. > > I was bored and had some free time, so I fixed up the port and put it in my > Redports SVN repo: > https://redports.org/browser/bsdkaffee/www/xombrero > Build logs here: > https://redports.org/buildarchive/20120731145106-5752/ > Clang build failed do to devel/gobject-introspection > > Feel free to use any of the changes I made. Many of the changes were > things I > said in my previous mail. > > I did away with the do-build target and left that up to bsd.port.mk by > defining MAKE_ARGS and BUILD_WRKSRC. This will make it easier in the > future > if you want to make the port use either webkit-gtk2 or webkit-gtk3 (when it > get in the ports tree). Plus we need to pass PTHREAD_CFLAGS and > PTHREAD_LIBS > to make. > > - Fixed some hardcoded paths and the use of -pthread directly in the > Makefile. > - Added -D_GCRYPT_IN_LIBGCRYPT=1 to the Makefile to squash the warnings. > - Moved one of the reinplaces to a proper patch. Reinplaces are more for > fixing paths and multiple instances of things. > > Regards, > Jason E. Hale > Thanks, Jason! You really helped a lot! I'll merge these changes to my files. HU Dong