From owner-freebsd-net@FreeBSD.ORG  Wed Jan 28 21:19:56 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3D0CDF25
 for <freebsd-net@freebsd.org>; Wed, 28 Jan 2015 21:19:56 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id F2E9099
 for <freebsd-net@freebsd.org>; Wed, 28 Jan 2015 21:19:55 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t0SLJtp0096896
 for <freebsd-net@freebsd.org>; Wed, 28 Jan 2015 21:19:55 GMT
 (envelope-from mat@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t0SLJtCq096894;
 Wed, 28 Jan 2015 21:19:55 GMT (envelope-from mat)
Date: Wed, 28 Jan 2015 21:19:55 +0000
To: freebsd-net@freebsd.org
From: "hselasky (Hans Petter Selasky)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D1711: Changes to the callout code to
 restore active semantics and also add a test-framework and test to validate
 thecallout code (and potentially for use by other tests).
Message-ID: <4f6927867f192f15826ff36ed897df80@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1711: Changes to the callout code to restore active semantics
 and also add a test-framework and test to validate the callout code (and
 potentially for use by other tests).
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-nb2boxugvmpo7syia5md>
X-Phabricator-To: <PHID-USER-sfbxp2cksgub2ywlvupr>
X-Phabricator-To: <PHID-USER-xs5piezwnsa6epounp3t>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-To: <PHID-USER-u62wa6uhdoiyjmodxchd>
X-Phabricator-To: <PHID-USER-s22ldiy33wseno7vfmzs>
X-Phabricator-To: <PHID-USER-mdwvnzzsrozqcmzhmbra>
X-Phabricator-Cc: <PHID-USER-fbdcs7ahjev7eqpeqr2a>
X-Phabricator-Cc: <PHID-USER-k4sj4wabur5mtroxrat2>
X-Phabricator-Cc: <PHID-MLST-c3bj6mfydtlqmuethodc>
In-Reply-To: <differential-rev-PHID-DREV-vhk6ww63dvpj6egspuyt-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-vhk6ww63dvpj6egspuyt-req@FreeBSD.org>
Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTJUns=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Jan 2015 21:19:56 -0000

hselasky added a comment.

Did you upload the correct patch?

INLINE COMMENTS
  sys/kern/kern_timeout.c:674 I don't mean inside the if (c_lock != NULL) { }
  There should be an else case after it.
  if (c_lock != NULL) {
   ... 
  } else {
     /* The callout cannot be stopped now */
    cc_exec_cancel(cc, direct) = true;  /* XXX this piece is missing */
  }
  
  Because else callout_stop() will return (1) when cancel() == false, which is a lie. It cannot stop the MPSAFE callout in this case and has to let it run ???

REVISION DETAIL
  https://reviews.freebsd.org/D1711

To: rrs, gnn, rwatson, imp, adrian, sbruno, lstewart, hselasky
Cc: neel, erj, freebsd-net