Date: Sun, 29 Feb 2004 18:00:32 -0600 From: "Brandon D. Valentine" <ports@brandon.dvalentine.com> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: freebsd-ports-bugs@freebsd.org Subject: Re: ports/63545: Today's portupgrade of linux-flashplugin to linux-flashplugin-6.0r79_1 breaks flash for linux-opera on FreeBSD-4.9Stable Message-ID: <20040301000032.GQ490@geekpunk.net> In-Reply-To: <1078096449.62463.46.camel@shumai.marcuscom.com> References: <200402292300.i1TN0ZSJ039160@freefall.freebsd.org> <1078096184.62463.44.camel@shumai.marcuscom.com> <1078096449.62463.46.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 29, 2004 at 06:14:09PM -0500, Joe Marcus Clarke wrote:
> On Sun, 2004-02-29 at 18:09, Joe Marcus Clarke wrote:
> > Convert this make conditional into a shell script conditional, and it
> > will work:
> >
> > @for f in ${LIBFILES}; do \
> > ${INSTALL_DATA} ${WRKSRC}/$${f} \ ${PREFIX}/lib/linux-flashplugin6;
> > \
> > if [ -d ${PREFIX}/${PLUGINSDIR} ]; then \
> > echo "Hi! I'm inside the if statement!"; \
> > ${LN} -sf \ ${PREFIX}/lib/linux-flashplugin6/$${f}; \
> > fi; \
> > done
> >
> > You never want to use exists on a directory anyway.
>
> I forgot to add, you will want to also do:
>
> .include <bsd.port.pre.mk>
>
> Before your targets so that variable expansion works as expected.
Thank you, Joe. That makes much more sense to me. FWIW, there are
several different places in bsd.port.mk which use exists on a directory.
I'm on my way out the door, but a patch will be forthcoming as soon as I
get home tonight.
Brandon D. Valentine
--
brandon@dvalentine.com http://www.geekpunk.net
Pseudo-Random Googlism: necco is committed to manufacturing the same
quality candy first manufactured
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040301000032.GQ490>