From owner-svn-src-all@freebsd.org Mon Mar 2 13:11:55 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B01FC1AE34B; Mon, 2 Mar 2020 13:11:55 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48WLBy4fm5z4PCl; Mon, 2 Mar 2020 13:11:54 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f47.google.com with SMTP id m22so5053915ioj.7; Mon, 02 Mar 2020 05:11:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FCy1AEYtH3GvAwTDryhWo5F+/c0qQrNYEBCPjIQ8iJM=; b=QqYok49GqnDqDAMMYRa3NVbBg3a0KX1OVNW/4N9LwOC4W6PcDPyp+HzmSshvftr6jX GQ/XI1QOkXm8WLxCLaK9EDr2G+8/suQSIhm8LkvsZVz2c+6YML9hrY3scYv0nsGNyhjw WCAOtAxNAsgzHK3PAfVpbp2XsF0HOEJlglJjAd3ogE5mw5M4XlhZ7s8M3KXmYrHlTi9Z RWNa1KRQL1s5+AkzOC+DCZQKXMmxxeIQ1eAH9hGS2OppDaZgRd4Kn+iWemljXbDuRkGn m4xFbudnVbTciLUQNkpk7rQecrmbFSqrPfdsXQtbVZPL/3TnvZpKN7Hq2z99dFWKIS8n CbLw== X-Gm-Message-State: APjAAAXpQi0oD6ylb3YUbaMytVrDvkp1W+sZf93DzhKXroql0prueJbW kqknAhhm+6fJ3UyWa8aeTlkPld2KlSzo1qcMpQUA9K7f X-Google-Smtp-Source: APXvYqzZjR4Ue1Ksp7C8JxLVr0VbUH0bxun/BazvZ2h8hHQLGUyaNn/noWagzKdVi+jVxbBo3R7v4vHfLx/oXht5djc= X-Received: by 2002:a6b:400b:: with SMTP id k11mr13083675ioa.256.1583154712503; Mon, 02 Mar 2020 05:11:52 -0800 (PST) MIME-Version: 1.0 References: <202003020422.0224Mdfa076913@repo.freebsd.org> In-Reply-To: <202003020422.0224Mdfa076913@repo.freebsd.org> From: Ed Maste Date: Sun, 1 Mar 2020 22:28:35 -0500 Message-ID: Subject: Re: svn commit: r358518 - head/usr.bin/elfctl To: Kyle Evans Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 48WLBy4fm5z4PCl X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Mar 2020 13:11:55 -0000 On Sun, 1 Mar 2020 at 23:22, Kyle Evans wrote: > > Author: kevans > Date: Mon Mar 2 04:22:38 2020 > New Revision: 358518 > URL: https://svnweb.freebsd.org/changeset/base/358518 > > Log: > elfctl: initialize features > > GCC points out a couple levels down in convert_to_features that this may be > used uninitialized. Indeed, this is true- initialize it to NULL so that we > at least deref a null pointer. Note that features is only used in the case that editfeatures = 1, so I believe this is a false positive from GCC. But, thank you for fixing the warning / build. This code code definitely use some style(9) and tidying; I'll try to get to that shortly.