From owner-svn-src-all@FreeBSD.ORG  Wed May 28 12:49:15 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5EA69E3;
 Wed, 28 May 2014 12:49:15 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id DCF4322FD;
 Wed, 28 May 2014 12:49:13 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.8/8.14.8) with ESMTP id s4SCn4OU083097
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 28 May 2014 16:49:04 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.8/8.14.8/Submit) id s4SCn4or083096;
 Wed, 28 May 2014 16:49:04 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 28 May 2014 16:49:04 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Hans Petter Selasky <hselasky@FreeBSD.org>
Subject: Re: svn commit: r266798 - head/usr.sbin/usbdump
Message-ID: <20140528124904.GI50679@FreeBSD.org>
References: <201405281227.s4SCRgKs038491@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201405281227.s4SCRgKs038491@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 May 2014 12:49:15 -0000

On Wed, May 28, 2014 at 12:27:42PM +0000, Hans Petter Selasky wrote:
H> Author: hselasky
H> Date: Wed May 28 12:27:41 2014
H> New Revision: 266798
H> URL: http://svnweb.freebsd.org/changeset/base/266798
H> 
H> Log:
H>   Fix for big endian architectures. The "up_address" field is 8-bit and
H>   does not need byte swapping.
H>   
H>   MFC after:	1 week

Do we need the assignment then? I'm surprised that compiler doesn't fail on that.

H> Modified:
H>   head/usr.sbin/usbdump/usbdump.c
H> 
H> Modified: head/usr.sbin/usbdump/usbdump.c
H> ==============================================================================
H> --- head/usr.sbin/usbdump/usbdump.c	Wed May 28 11:30:37 2014	(r266797)
H> +++ head/usr.sbin/usbdump/usbdump.c	Wed May 28 12:27:41 2014	(r266798)
H> @@ -473,7 +473,7 @@ print_apacket(const struct header_32 *hd
H>  	 */
H>  	up->up_totlen = le32toh(up->up_totlen);
H>  	up->up_busunit = le32toh(up->up_busunit);
H> -	up->up_address = le32toh(up->up_address);
H> +	up->up_address = up->up_address;
H>  	up->up_flags = le32toh(up->up_flags);
H>  	up->up_status = le32toh(up->up_status);
H>  	up->up_error = le32toh(up->up_error);

-- 
Totus tuus, Glebius.