From owner-cvs-src@FreeBSD.ORG Tue Sep 19 22:23:55 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B2F216A4C2; Tue, 19 Sep 2006 22:23:55 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 06B1443D45; Tue, 19 Sep 2006 22:23:54 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k8JMNqhH087939; Tue, 19 Sep 2006 18:23:52 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Martin Blapp Date: Tue, 19 Sep 2006 17:14:46 -0400 User-Agent: KMail/1.9.1 References: <200609191925.k8JJPBaH091145@repoman.freebsd.org> In-Reply-To: <200609191925.k8JJPBaH091145@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200609191714.46864.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 19 Sep 2006 18:23:52 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/1905/Tue Sep 19 16:43:42 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2006 22:23:55 -0000 On Tuesday 19 September 2006 15:25, Martin Blapp wrote: > mbr 2006-09-19 19:25:11 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_proc.c > Log: > Fix races between tty.c and sessrele() / doenterpgrp() / leavepgrp(). The tty > code is still under giant lock, but the session/pgrp release code just used > proctree_locks. This explains why moving the proctree_lock in sys/kern/tty.c > rev. 1.258 did fix the panics in our SMP systems. > > This should also fix some race panics with revoked ttys. > > Reviewed by: jhb > MFC after: 1 week Will you be able to revert 1.258 of tty.c now and still be safe from panics? -- John Baldwin