From owner-svn-ports-all@freebsd.org Fri Apr 13 08:42:29 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6BF2BF9AE83 for ; Fri, 13 Apr 2018 08:42:29 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0592D7E2A5 for ; Fri, 13 Apr 2018 08:42:28 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: by mail-io0-x22f.google.com with SMTP id q84so9400800iod.10 for ; Fri, 13 Apr 2018 01:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sunpoet-net.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=rQccqOLKm9iR79DcyaVIyLr2uOkJ/QHnDazNHMN3YEk=; b=L+6dtNOr0qQ/dwZ2cEfuF2TzVBPg3A3JfLyuJILDpez6ekkMHYsqTKTNNSeIX/bAkU 7kYEqPoJqUbUFbq3abVmH0dEE9G0ux0XgSZzdHrdvFJdDNBiMzRrKHbp6a6WsAzQEeho 1Yku00FORvjhVuCDOvJaeK/9RuP2LqDNuJKm7Oi3D3fP6twzNGhsp3tAxFHr22xJ+lLO uzGSIxj8LGjgly/w8EQwKiXip/U3hdWCDN4Mwr4udg3+QrWITPvobK8FzTLCedK1qJNP GHoqKvO7LMTmJ52EZduv2YADnThRerGm1F1B0o4ai7lTt3zbzEwUBP/N7P2//RkJ873a Vf1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=rQccqOLKm9iR79DcyaVIyLr2uOkJ/QHnDazNHMN3YEk=; b=jp3dvxycWKf5dB9Jaonrj5mJk6u1mRI23dxzsMmCxBxplISpsf+Nah4aWlGoHEYzy2 sXTtuN2dM7A0gWT60YPH1orNQrQspEGkLessT7128cD80IifDKWSDrI4uQoUeNJUN3pH J4ScypWP7Gi5xrFIJv9UE+tu274sAHsg6TXVI9C18BylH/H3jAJ4QBxKxGvtF+2bD3Nn fifSLkqgmQpaJYsySDZkuF4TCzL5ZE0b56IxxFYvAOt4tZ5LzDz/sgTVhbmQ0zcpJpEL Q7Noifzn/biWsgew93HvRI6rdztndU7X9q7L4mo0biBo6XlpOnn7V+/sa7Ahp+nK4osl qW5Q== X-Gm-Message-State: ALQs6tD4F/7B0gsSfYekC8xRyPY6L/VIkY6O/DGmhhPXk6zTpggQT/1u xYn0e3KgltoDvCKXlW2W6Eq8keKV6StPsvaNxStApYjvfjM= X-Google-Smtp-Source: AIpwx49i/J1AKUYjdh3AbCPgKloRFm31OifW5RWnrcZmI6uypJtzbq7WozElcDqLPGJxG472PXKWQio8PC3oODXTwBM= X-Received: by 10.107.130.95 with SMTP id e92mr12140747iod.264.1523608948119; Fri, 13 Apr 2018 01:42:28 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.2.57.13 with HTTP; Fri, 13 Apr 2018 01:41:47 -0700 (PDT) In-Reply-To: References: <201804121833.w3CIXtgW077267@repo.freebsd.org> From: Sunpoet Po-Chuan Hsieh Date: Fri, 13 Apr 2018 16:41:47 +0800 X-Google-Sender-Auth: CuEtfvdWDFNTgUjGJp1XNiA0G5k Message-ID: Subject: Re: svn commit: r467193 - in head/www/gitlab: . files To: Matthias Fechner Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 08:42:29 -0000 On Fri, Apr 13, 2018 at 4:01 AM, Matthias Fechner wrote: > Dear sunpoet, > > Am 12.04.2018 um 20:33 schrieb Sunpoet Po-Chuan Hsieh: > > Log: > > Fix Gemfile for rubygem-default_value_for 3.1.0 update > > > > - Bump PORTREVISION for package change > > > > Modified: > > head/www/gitlab/Makefile > > head/www/gitlab/files/patch-Gemfile > I really enjoy your work and it is totally fine for me, if you upgrade a > gem that you copy the old one and make sure that gitlab uses the old. > (like you did with r467106, thanks a lot for this!) > > But please do not start to patch the Gemfile! > This will break gitlab. Have you tested gitlab with this modification? > (for sure not, I reported exactly that version of default_value_for > upstream and they rolled back the change as it broke gitlab, they broke > 3.0.4 and rolled back the modification with 3.0.5, now you changed > gitlab to use the version that for sure will not work!) > > Please revert this modification and ask me (the maintainer) before you > start to modify the port I maintain. > Thanks a lot that you understand this. > Hi, I think that default_value_for 3.0.4 update is a different case. gitlab wats default_value_for ~> 3.0.0 and it fits the rule. I would like to keep less number of gems with multiple versions in the ports tree. It will sometimes make the dependency tree complex. Therefore, I would not copy the old version unless it's necessary. In this case, the only change between default_value_for 3.0.5 and 3.1.0 is Rails 5.2 support [1]. I don't think it breaks gitlab. Can you please confirm if it really breaks gitlab? If so, I'll revert it as soon as possible. Thanks, sunpoet [1] https://github.com/FooBarWidget/default_value_for/commit/2d1802cf4836eb6dd7= 2f1469378e383e79f83fdf > Gru=C3=9F > Matthias > > -- > > "Programming today is a race between software engineers striving to > build bigger and better idiot-proof programs, and the universe trying to > produce bigger and better idiots. So far, the universe is winning." -- > Rich Cook > > >