Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 12 Nov 2012 14:19:05 +0000 (UTC)
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org
Subject:   svn commit: r242919 - stable/7/usr.sbin/pw
Message-ID:  <201211121419.qACEJ5sH031927@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bapt
Date: Mon Nov 12 14:19:05 2012
New Revision: 242919
URL: http://svnweb.freebsd.org/changeset/base/242919

Log:
  MFC: r241107, r241108
  
  Remove useless atoi(3), previous strspn(3) makes sure that a_name->val is a
  number.
  This also allow pw user show to work as expected.
  
  PR:		bin/172112
  Submitted by:	Ilya A. Arkhipov <rum1cro@yandex.ru>

Modified:
  stable/7/usr.sbin/pw/pw_user.c
Directory Properties:
  stable/7/usr.sbin/pw/   (props changed)

Modified: stable/7/usr.sbin/pw/pw_user.c
==============================================================================
--- stable/7/usr.sbin/pw/pw_user.c	Mon Nov 12 14:16:39 2012	(r242918)
+++ stable/7/usr.sbin/pw/pw_user.c	Mon Nov 12 14:19:05 2012	(r242919)
@@ -325,7 +325,7 @@ pw_user(struct userconf * cnf, int mode,
 		 */
 		if (mode != M_ADD && pwd == NULL
 		    && strspn(a_name->val, "0123456789") == strlen(a_name->val)
-		    && atoi(a_name->val) > 0) {	/* Assume uid */
+		    && *a_name->val) {
 			(a_uid = a_name)->ch = 'u';
 			a_name = NULL;
 		}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201211121419.qACEJ5sH031927>