From nobody Mon Apr 10 07:24:17 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pw0pT6lFcz44vJR for ; Mon, 10 Apr 2023 07:24:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pw0pT2nQ4z3BwF for ; Mon, 10 Apr 2023 07:24:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681111457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4SQrAQVDfe7788UBJfa4VFBR01AEVGHPJpzyQ9wAAQk=; b=WfSOqFV3Q2nzwwYtK+9rRvsn8C95QPpdSXcaPwfyY92eCBOjzi+qJY1SGdnXB8BEMVFHrl QmV5ziYJpbd0jzh2mbDWQ3YNTOOGcpTwnFBuOP/4wWbKyUnt5hN0GSEj19o7vP432gk+Wq mKqA024qsHcGdcnYNRLXPfHLA260AAdk+bOZrlUypbHUf/OGLVMgumxevkHZQ16Ciw1naD R5MU6syYgMHeOZmAtakqOZWLrtEjZvYN8q/FwT+KNTj/ATEbGvkBs/65an8Ljei2sQ7W8k yb4FKAS+KMpl767KFSahMskiDojo8Ze1yavFuCtJWJMfTAD+wHkS41HLo7vgWg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681111457; a=rsa-sha256; cv=none; b=xlJ+7kzX+wkUXYkSvGIWZQm5iApOHyoUjoKFFcVxBMmw9l0VXUXS97ZnK3yl2vZKsSt1Lh HEVwMS/9/5tNfFQ8UM4DsNmMF6UDf4ttKnIxsFRTLBhhce5U7ke4g3PZqg4uEuT8Y40zl7 D0OCYZRBTpL8jjCChf80ndGwp7yDsitPDzI8Wm1dYCgRI6GN2tDykfi63KZ4sr8i73TrgK oEc7+SeXLgJN+iW9nHLb0d9UQFLSCMxO1nh9muzhUjOAyVwKOo4r6xqHsM2gJQIEpxJnAI /+Mb0A7YATy4WonbGQ7L9uyK0TY42c7I3r5DkpL00Xmgq06ScfB1iqQQJWagZQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Pw0pT1f6nzhJH for ; Mon, 10 Apr 2023 07:24:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 33A7OHGQ055385 for ; Mon, 10 Apr 2023 07:24:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 33A7OHYQ055384 for net@FreeBSD.org; Mon, 10 Apr 2023 07:24:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 270559] if_bridge: does not forward packets properly for vlan 1 Date: Mon, 10 Apr 2023 07:24:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: philip@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270559 --- Comment #8 from Philip Paeps --- Our if_bridge(4) really only implements the learning and forwarding parts of the original 802.1D standard. It's really only aware of VLANs because if_vlan(4) puts the relevant tags in the mbuf. It does not try to be a complete implementation of 802.1Q-2014 (which incorporates bridging, VLANs = and some other stuff). The comment introducing the VLANTAGOF(_m) macro is a little confusing if th= is patch is applied as-is. I'm also not convinced that this change is correct= .=20 VLAN 0 is not a valid VID but it's perfectly possible for a dot1q tag with VID=3D0 to appear on the wire: it indicates untagged traffic with a PCP or = the DEI bit set. I wonder if we should use 0xFFF rather than 0 as the magic number for untag= ged frames. 0xFFF is reserved in 802.1Q-2014 for implementation use. Did either of you test what happens if a packet with a dot1q header that on= ly contains a PCP and not a VID gets forwarded? --=20 You are receiving this mail because: You are the assignee for the bug.=