From owner-freebsd-arch@FreeBSD.ORG Thu Oct 1 13:07:58 2009 Return-Path: Delivered-To: arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0DD1C1065679 for ; Thu, 1 Oct 2009 13:07:58 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 549DA8FC25 for ; Thu, 1 Oct 2009 13:07:57 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA03652; Thu, 01 Oct 2009 15:49:43 +0300 (EEST) (envelope-from avg@icyb.net.ua) Message-ID: <4AC4A567.7050204@icyb.net.ua> Date: Thu, 01 Oct 2009 15:49:43 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: John Baldwin References: <200909301732.20589.jhb@freebsd.org> In-Reply-To: <200909301732.20589.jhb@freebsd.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: arch@FreeBSD.org Subject: Re: Interrupt Descriptions X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2009 13:07:58 -0000 on 01/10/2009 00:32 John Baldwin said the following: > A few folks have asked recently for the ability to add descriptive strings to > registered interrupt handlers. This is especially true since the advent of > MSI with multiple interrupts per device. I hacked up a prototype today that > adds a new 'bus_describe_intr()' that takes the IRQ resource, the void * > cookie returned by bus_setup_intr() and var args description and appends that > to the interrupt name in the thread and vmstat -i info. The current patch > only has the MI bits and the MD bits for amd64 as well as a sample change to > the igb(4) driver. > > The patch is at http://www.FreeBSD.org/~jhb/patches/intr_describe.patch. > > An example from this patch is: > >> vmstat -i > interrupt total rate > irq1: atkbd0 8 0 > irq4: uart0 751 5 > irq6: fdc0 6 0 > irq14: ata0 36 0 > irq20: uhci0 20 0 > irq23: uhci3 ehci0 2 0 > irq28: mpt0 1661 11 > irq256: igb0:tx 0 880 6 > irq257: igb0:rx 0 1098 7 > irq258: igb0:link 3 0 > irq259: igb1:tx 0 1 0 > irq260: igb1:rx 0 134 0 > irq261: igb1:link 3 0 > Example above doesn't demonstrate what happens when there are shared interrupts. Would it still look nice (with sufficiently long descriptions)? -- Andriy Gapon