From nobody Thu Apr 23 19:17:47 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g1m811b6rz6bMkV for ; Thu, 23 Apr 2026 19:17:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g1m804p1fz3jrY for ; Thu, 23 Apr 2026 19:17:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776971872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yiifSXM8KnJBa7Rqne/OMECOBpYKR3fh4WweGeJ3LxA=; b=uKP2HgxKwfPk2qP7nNlj1n6ECSfocTykVpFbdPhjHy+bj67FertNigX5b/3FOYPtywioXY lZf4c67wwJgKdHCEFp/qhe+gaaJ/NaeIfLKWPR13o2womTwd/AqJ5bcZWEUMpzqnadW5Iz XvDeciaayOwF0TVHv3eBkovii9cTroX68Kq59WMOO0Z7WjXqXkMiC7KK33lBXXyFKKWclw YBplqJ7cHnp7klJmcB/UNAx1kLhDyp9fdbTV+dP3Ag5E47FGIcs5nm24DS13YuFj94NH4t j0GcwY1bfRM0/rg6lWsJUGaACP6xKaX0RcAJODBs7kWYQ1xHenN+dvIYcKblRw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776971872; a=rsa-sha256; cv=none; b=vKiL0oaqnIZj1gndzaJN3RAZ2zRolt5RdEIuQiCJRqXKV4gVD0xgJOJOHBFb4jc6UEfQ89 LJ+WAA9diziYgXnOJ3oWZ0lWHt8pnbHFX6TVvTeKzQ90+y+DpioH1vgo4M33e73OqSZt68 ES286YbAkc4EfldekFNGpb6ujtyuJGiN5qxnIslDm7VNBzu/3WwbZbRWDMz6BRIsIVSI6Y 9NkMTO05pkcySlTZKSPcUX4GJ1a8iZEPeHyiyrU2QQaXl6ZQYVRrvMRDFznh3iwvyayIoB v9SezZA98LiHiQOKsc96PxOHGwgeQuUb7qRUDfLAXgEISTWCUOM2ZBxB6UjmKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776971872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yiifSXM8KnJBa7Rqne/OMECOBpYKR3fh4WweGeJ3LxA=; b=UnNxjoUcJXVQhvthwj+g06NJyu7heTFr1RH1e1RJH4VihofWWWH+/1+rin4Z88Gis6rC9C TpBQDhhGMPAUTjaqCPB/bCgesxl65dPz9yREteFRM62yR+Sw87LRLqOgf01EKOap4xOcnD C3qJ0oGilnentOB0lKNKtG0YviZmkhzd8Wpg8Z6OuxiN87cDgw0MJ7pNIG88MWr7s2pYKa a3IyFeY9I51eL64+7TyLIYaT09r5awMxrjCzhqJf9Q2CLEiI66DY4GjIIa9MkpOOYH0P3M pk/0+gpHQ3ArsHNwiv+EOErUEiCriPb+8DOZeHOI3BDH01KbkI6/7xlIGUhVSg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g1m803RVZzVFT for ; Thu, 23 Apr 2026 19:17:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1d9e7 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 23 Apr 2026 19:17:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Ken J. Thomson From: John Baldwin Subject: git: 614ef718496e - main - ctld: Don't add an iscsi port for targets with only kernel ports List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 614ef718496eb6fd815ddcfde203bee8da1178b1 Auto-Submitted: auto-generated Date: Thu, 23 Apr 2026 19:17:47 +0000 Message-Id: <69ea705b.1d9e7.7ff62d32@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=614ef718496eb6fd815ddcfde203bee8da1178b1 commit 614ef718496eb6fd815ddcfde203bee8da1178b1 Author: Ken J. Thomson AuthorDate: 2026-04-23 19:15:48 +0000 Commit: John Baldwin CommitDate: 2026-04-23 19:15:48 +0000 ctld: Don't add an iscsi port for targets with only kernel ports PR: 293076 Reviewed by: asomers Fixes: 969876fcee57 ("ctld: parse config file independently of getting kernel info") Differential Revision: https://reviews.freebsd.org/D56523 --- usr.sbin/ctld/ctld.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/ctld/ctld.cc b/usr.sbin/ctld/ctld.cc index b634debeafc8..e3050974dd35 100644 --- a/usr.sbin/ctld/ctld.cc +++ b/usr.sbin/ctld/ctld.cc @@ -1461,7 +1461,7 @@ target::verify() t_auth_group = t_conf->find_auth_group("default"); assert(t_auth_group != nullptr); } - if (t_ports.empty()) { + if (t_ports.empty() && t_pports.empty()) { struct portal_group *pg = default_portal_group(); assert(pg != NULL); t_conf->add_port(this, pg, nullptr);