From owner-freebsd-current@FreeBSD.ORG Wed Dec 28 06:25:33 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 565DE16A41F; Wed, 28 Dec 2005 06:25:33 +0000 (GMT) (envelope-from dmitry@atlantis.dp.ua) Received: from postman.atlantis.dp.ua (postman.atlantis.dp.ua [193.108.47.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 34A4543D46; Wed, 28 Dec 2005 06:25:27 +0000 (GMT) (envelope-from dmitry@atlantis.dp.ua) Received: from smtp.atlantis.dp.ua (smtp.atlantis.dp.ua [193.108.46.231]) by postman.atlantis.dp.ua (8.13.1/8.13.1) with ESMTP id jBS6PJHS008499; Wed, 28 Dec 2005 08:25:19 +0200 (EET) (envelope-from dmitry@atlantis.dp.ua) Date: Wed, 28 Dec 2005 08:25:19 +0200 (EET) From: Dmitry Pryanishnikov To: John Baldwin In-Reply-To: <200512271131.16479.jhb@freebsd.org> Message-ID: <20051228075749.B57227@atlantis.atlantis.dp.ua> References: <20051225135216.Y1294@atlantis.atlantis.dp.ua> <20051226014329.152c6918.nork@FreeBSD.org> <200512271131.16479.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Mailman-Approved-At: Wed, 28 Dec 2005 06:32:55 +0000 Cc: freebsd-current@freebsd.org, Norikatsu Shigemura Subject: Re: vgapci doesn't want to attach agp on ASUS M5A X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Dec 2005 06:25:33 -0000 Hello! On Tue, 27 Dec 2005, John Baldwin wrote: >> I have same problem in my i830M, too and fixed Dmitry's patch. >> According to my pciconf -rb, pci_find_extcap(dev, PCIY_AGP, NULL) >> never find PCIY_AGP(because of 0x01). > > Ok. I don't see any patch anywhere, It's trivial: --- vga_pci.c.orig Thu Dec 22 18:25:22 2005 +++ vga_pci.c Sun Dec 25 13:04:09 2005 @@ -74,7 +74,7 @@ * If AGP capabilities are present on this device, then create * an AGP child. */ - if (pci_find_extcap(dev, PCIY_AGP, NULL) == 0) +// if (pci_find_extcap(dev, PCIY_AGP, NULL) == 0) device_add_child(dev, "agp", -1); > but it sounds like you'll need to fix the > DRM driver to not expect an AGP capability for this specific card or some > such. I'm not sure here. Yes, Intel's Mobile 915 PM/GM/GMS and 910GML Express Chipsets don't claim AGP capability. But they still contain AGP-related registers for compatibility. Moreover, we've just added those chipsets support to our sys/pci/agp_i810.c! So now we have an inconsistency between agp_i810.c and vga_pci.c and this should be fixed in order to get working DRM on those chipsets (people DO report that this hack makes DRM happy, I've not tried to explore it's actual functionality under XFree yet). For long-term solution, maybe we should have PCI Express-specific module which should attach to vga_pci and provide service similar to agp module. Sincerely, Dmitry -- Atlantis ISP, System Administrator e-mail: dmitry@atlantis.dp.ua nic-hdl: LYNX-RIPE