From owner-svn-src-all@FreeBSD.ORG Mon May 30 19:26:34 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB70D106566B; Mon, 30 May 2011 19:26:34 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-annu.mail.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id 4A49F8FC08; Mon, 30 May 2011 19:26:33 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ap0EAOHu402DaFvO/2dsb2JhbABVhEmiWIhxqwiQNIErg2yBBwSQT482 X-IronPort-AV: E=Sophos;i="4.65,293,1304308800"; d="scan'208";a="122340554" Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.206]) by esa-annu-pri.mail.uoguelph.ca with ESMTP; 30 May 2011 15:26:33 -0400 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 44878B40DE; Mon, 30 May 2011 15:26:33 -0400 (EDT) Date: Mon, 30 May 2011 15:26:33 -0400 (EDT) From: Rick Macklem To: Robert Watson Message-ID: <813868799.1015531.1306783593226.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.91.202] X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - IE7 (Win)/6.0.10_GA_2692) Cc: svn-src-head@freebsd.org, Rick Macklem , svn-src-all@freebsd.org, src-committers@freebsd.org, Kostik Belousov Subject: Re: svn commit: r222466 - head/sbin/umount X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 May 2011 19:26:35 -0000 > > No doubt. :-) > > If the sync(2) has actual consistency and reliability benefits, it > should > probably be done by the umount(2) system call, so that other future > auto-mounters, etc, also get the same result, rather than having to > encode it > in every application. If it's done on blind faith, perhaps it > shouldn't be > done at all. > I wouldn't say it's necessary, but if you look at dounmount() in vfs_mount.c, it does a VFS_SYNC() before VFS_UNMOUNT(). I needed to fix nfs_sync() for forced dismounts to work because of this. rick