From owner-svn-src-projects@FreeBSD.ORG Thu Oct 9 21:21:22 2014 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B9DF069A; Thu, 9 Oct 2014 21:21:22 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 92B52D14; Thu, 9 Oct 2014 21:21:22 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 87934B941; Thu, 9 Oct 2014 17:21:21 -0400 (EDT) From: John Baldwin To: "Alexander V. Chernikov" Subject: Re: svn commit: r272515 - projects/ipfw/sys/netpfil/ipfw Date: Thu, 9 Oct 2014 17:11:28 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; ) References: <201410041210.s94CAX7I012628@svn.freebsd.org> <5520708.eFNh9vYom7@ralph.baldwin.cx> <5436B52E.3010106@FreeBSD.org> In-Reply-To: <5436B52E.3010106@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Message-Id: <201410091711.28587.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 09 Oct 2014 17:21:21 -0400 (EDT) Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Oct 2014 21:21:22 -0000 On Thursday, October 09, 2014 12:17:50 pm Alexander V. Chernikov wrote: > On 06.10.2014 19:45, John Baldwin wrote: > > On Saturday, October 04, 2014 12:10:33 PM Alexander V. Chernikov wrote: > >> Author: melifaro > >> Date: Sat Oct 4 12:10:32 2014 > >> New Revision: 272515 > >> URL: https://svnweb.freebsd.org/changeset/base/272515 > >> > >> Log: > >> Add "ipfw_ctl3" FEATURE to indicate presence of new ipfw interface. > >> > >> Modified: > >> projects/ipfw/sys/netpfil/ipfw/ip_fw2.c > >> > >> Modified: projects/ipfw/sys/netpfil/ipfw/ip_fw2.c > >> ============================================================================ > >> == --- projects/ipfw/sys/netpfil/ipfw/ip_fw2.c Sat Oct 4 11:40:35 > >> 2014 (r272514) +++ projects/ipfw/sys/netpfil/ipfw/ip_fw2.c Sat Oct 4 > >> 12:10:32 2014 (r272515) @@ -2874,6 +2874,7 @@ static moduledata_t ipfwmod = > >> { > >> #define IPFW_VNET_ORDER (IPFW_MODEVENT_ORDER + 2) /* Later still. */ > >> > >> DECLARE_MODULE(ipfw, ipfwmod, IPFW_SI_SUB_FIREWALL, IPFW_MODEVENT_ORDER); > >> +FEATURE(ipfw_ctl3, "ipfw new sockopt calls"); > >> MODULE_VERSION(ipfw, 2); > >> /* should declare some dependencies here */ > > Would it be better to bump the module version to 3 instead? Userland programs > > can then use modfind() and modstat() to determine the version. > I've bumped ipfw module version in r272828. Actually, I've entirely > forgotten about this possibility. > However, it is a bit hard to determine module version inside > (perl|python|sh|any) script. > On the other case, FEATURE framework provides nice and easy way to > determine any "feature" status > both in C and interpreted programs. I'll grant you that feature is convenient. Perhaps create a SYSCTL node though that holds the current version? That is 'foo.ipfw.version' being 2 or 3 is more future proof than 'feature.ipfw2/3/4'. Alternatively, we could change the module code to export a dynamic sysctl tree for all loaded modules that includes the versions, i.e. 'module..version', etc. -- John Baldwin