From owner-cvs-src Mon Feb 17 19:32:32 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1CB5537B401; Mon, 17 Feb 2003 19:32:30 -0800 (PST) Received: from dilbert.robbins.dropbear.id.au (205.b.011.mel.iprimus.net.au [210.50.217.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A4D043F93; Mon, 17 Feb 2003 19:32:27 -0800 (PST) (envelope-from tim@robbins.dropbear.id.au) Received: from dilbert.robbins.dropbear.id.au (9bxw8flnw1tik6f4@localhost [127.0.0.1]) by dilbert.robbins.dropbear.id.au (8.12.6/8.12.6) with ESMTP id h1I3WNKO021812; Tue, 18 Feb 2003 14:32:24 +1100 (EST) (envelope-from tim@dilbert.robbins.dropbear.id.au) Received: (from tim@localhost) by dilbert.robbins.dropbear.id.au (8.12.6/8.12.6/Submit) id h1I3WM5b021811; Tue, 18 Feb 2003 14:32:22 +1100 (EST) (envelope-from tim) Date: Tue, 18 Feb 2003 14:32:22 +1100 From: Tim Robbins To: Marcel Moolenaar Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/sh machdep.h memalloc.c nodes.c.pat Message-ID: <20030218143222.A21049@dilbert.robbins.dropbear.id.au> References: <200302180208.h1I28Kbu046465@repoman.freebsd.org> <20030218022850.GB1973@athlon.pn.xcllnt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.5.1i In-Reply-To: <20030218022850.GB1973@athlon.pn.xcllnt.net>; from marcel@xcllnt.net on Mon, Feb 17, 2003 at 06:28:51PM -0800 Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Feb 17, 2003 at 06:28:51PM -0800, Marcel Moolenaar wrote: > On Mon, Feb 17, 2003 at 06:08:20PM -0800, Tim J. Robbins wrote: > > tjr 2003/02/17 18:08:20 PST > > > > Modified files: > > bin/sh memalloc.c nodes.c.pat > > Added files: > > bin/sh machdep.h > > Log: > > Revert ALIGN change for the second and last time. I can't figure out > > why this is breaking sparc64. > > Hmmm.... Maybe this is what's breaking ia64 as well. I just bumped > _ALIGNBYTES from 7 to 15 and the argument passing seems to be > screwed. Is that that what you see as well? Not quite, the "\320" chars from malloc()'s J flag were being appearing in places. On panther: install-info --quiet --defsection="Gcc Documentation" --defentry="* cppinternals: (cppinternals). The GNU compiler preprocessor internal documentation." cppinternals.info /usr/share/info/dir install-info: excess command line argument `/usr/share/info/dir' install-info: No such file or directory for 行行行行行行行行 *** Error code 1 I think the problem could have been that the initial stack block in memalloc.c wasn't being aligned correctly, which I overlooked when adding the alignment stuff to stalloc(): char *stacknxt = stackbase.space; int stacknleft = MINSIZE; Try this (ugly) patch: http://people.freebsd.org/~tjr/align.diff Tim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message