From owner-svn-ports-head@freebsd.org Sun Mar 22 22:50:53 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 77EAA26FF4C; Sun, 22 Mar 2020 22:50:53 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48lt5m1lVtz4Zt0; Sun, 22 Mar 2020 22:50:52 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id 6499958A4A; Sun, 22 Mar 2020 23:50:43 +0100 (CET) Date: Sun, 22 Mar 2020 23:50:42 +0100 From: Piotr Kubaj To: Kyle Evans Cc: Gerald Pfeifer , Baptiste Daroussin , Kubilay Kocak , vbox@freebsd.org, ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r528258 - in head/emulators/virtualbox-ose: . files Message-ID: <20200322225042.GB12035@KGPE-D16> References: <202003120041.02C0fXkP049507@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CUfgB8w4ZwR/yMy5" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 48lt5m1lVtz4Zt0 X-Spamd-Bar: ------- X-Spamd-Result: default: False [-7.23 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:46.248.190.61]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; IP_SCORE(-2.83)[ip: (-9.91), ipnet: 46.248.160.0/19(-4.69), asn: 47544(0.37), country: PL(0.06)]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DMARC_POLICY_ALLOW(-0.50)[anongoth.pl,reject]; RCPT_COUNT_SEVEN(0.00)[8]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2020 22:50:53 -0000 --CUfgB8w4ZwR/yMy5 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline On 20-03-22 17:47:43, Kyle Evans wrote: >On Sun, Mar 22, 2020 at 5:40 PM Gerald Pfeifer wrote: >> >> On Thu, 12 Mar 2020, Kyle Evans wrote: >> > Log: >> > emulators/virtualbox-ose: use contemporary GCC instead of old llvm >> >> This patch does not exactly do that. =:o >> >> > +# machine/atomic.h may use features that are only available in GCC9. This is >> > +# a workaround, anyways- we should be expressing USES= compiler:c++14-lang, but >> > +# contemporary clang miscompiles virtualbox in some fashion and yields runtime >> > +# breakage. >> > +USE_GCC= any >> >> USE_GCC=any allows using the age old, rotten, GCC 4.2 based system >> compiler where still present. >> >> This is practically not the case with ONLY_FOR_ARCHS= i386 amd64 which >> this port also specifies, but that is a subtle and indirect approach. >> >> (Where there is no /usr/bin/gcc USE_GCC=any degenerates to USE_GCC=yes, >> so the two are practically equivalent here, but still the USE_GCC=yes >> form is the one requiring a current version.) >> >> Okay to change this to USE_GCC=yes? >> For building with GCC and linking to libc++ instead of libstdc++, one can use USES=compiler:gcc-c++11-lib. > >It's actually needing to be changed back away from GCC, because this >inherently breaks as the qt bits it uses are compiled with llvm and >used an incompatible libc++ -- there's an open PR about it after this >commit, I'm trying to work out where newer clang is failing to compile >properly. =-( > >> Gerald >> >> PS: How do patches to this port actually get approved? The log has >> hardly any Approved by-s. > >I seem to recall the situation is that there's now an effectively >one-man vbox@ team, and this seems to be mostly on life-support. There >is a long-standing PR to push virtualbox-ose to 6.x, but I don't >recall if that was being ushered through by vbox@ or not. --CUfgB8w4ZwR/yMy5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl5368IwFIAAAAAAFQAS cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug g5ydTEcQAJAu/TRTW4ERK3jGdiZXo0REZ8Os7o+nzJC6sV6tETEWvOJOxRavlBwN SzSJ4Pb0+vwA/vQbNS0uuVFtu96qYiHPdNMZEO4hd5jYVywbkVYxnOuHNDAixyTy p6lGlSOhxngS7yHSaO4fmjTJhMkWTKnqPybNxd4rbFm6/jvaVWPAzpp8h7YIi013 hbaumvqVn6QJMhKqPa0G/hql+kFcVpS6ST01toQr2TxC6p8IjzQKvDfVcFfw5+W8 y24TkMZ/iIE9lWVgTdZ2iieTRJKdJ1XyUNv+VoQh5Cfih8ptDDP8eZxTHHVGKBSH VNcPaGhTydeoMFE/s6/lQvGPC4ccy7pLaC3z0Po/PmJ/pf0XcjIH2/BSUYeNh9xE md3gvQ1GeZXHcUyZztcBsJ8Y+4qnRlmyiku2sc/deY+kshDmZc/1DZRggcsXNybo t1CtylJ8Hb6zVveYCcGlgzOFX3D+tKXsOKiNrgC0RZrrMJ7KzmsJB6I1dgbfxAOA ZzsDbti8xuSS3OHpuxKV9+kEWFMMiFoKOoDXLGPcTON25vWRxDfDUowZZLR7GPDi 0cYLhF6YiMf36K86zuY5iOG5aySYYWryPML4WWVR3K2AHlkqGA2Lujw9nw+LmPGy lTLB8o3LFvU7KT9QpjrnZ9xbNVG/bivceI9joVyAmJ0AuRXX9Ik3 =tZ7D -----END PGP SIGNATURE----- --CUfgB8w4ZwR/yMy5--