From owner-freebsd-ports@FreeBSD.ORG  Thu Jun 23 07:41:21 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 30AB7106564A;
	Thu, 23 Jun 2011 07:41:21 +0000 (UTC)
	(envelope-from micro@heavennet.ru)
Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com
	[209.85.161.54])
	by mx1.freebsd.org (Postfix) with ESMTP id DF9B18FC0A;
	Thu, 23 Jun 2011 07:41:19 +0000 (UTC)
Received: by fxm11 with SMTP id 11so1662060fxm.13
	for <multiple recipients>; Thu, 23 Jun 2011 00:41:18 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.223.32.142 with SMTP id c14mr2209204fad.59.1308814877905; Thu,
	23 Jun 2011 00:41:17 -0700 (PDT)
Received: by 10.223.109.202 with HTTP; Thu, 23 Jun 2011 00:41:17 -0700 (PDT)
In-Reply-To: <20110623033052.GA23118@FreeBSD.org>
References: <20110621214013.6cc4760e@heavennet.ru>
	<20110622020048.GA83940@FreeBSD.org>
	<BANLkTi=En+7nJgEmKCmBEQMwiV0nbcPhEg@mail.gmail.com>
	<20110622064224.GB94185@FreeBSD.org>
	<BANLkTi=s6zYOJJv6+kk+ttd7jadmTuaT6w@mail.gmail.com>
	<20110622160233.8b6156e1.itetcu@FreeBSD.org>
	<20110622135941.GA99725@FreeBSD.org>
	<e645505a-06bd-461d-b4a6-3f4436caef24@email.android.com>
	<BANLkTim+46u3H9tUp-EqS1PKKtfKZ2KQTw@mail.gmail.com>
	<20110623033052.GA23118@FreeBSD.org>
Date: Thu, 23 Jun 2011 11:41:17 +0400
Message-ID: <BANLkTi=fiYsp-fJY97TkTyXWOCS0-CrQTg@mail.gmail.com>
From: "Ilya A. Arkhipov" <micro@heavennet.ru>
To: Alexey Dokuchaev <danfe@freebsd.org>
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: Chris Rees <crees@freebsd.org>, ports@freebsd.org,
	Ion-Mihai Tetcu <itetcu@freebsd.org>,
	Joe Marcus Clarke <marcus@freebsd.org>, kwm@freebsd.org
Subject: Re: portlint(1) knobs order: let's make things more logical
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jun 2011 07:41:21 -0000

23 =C9=C0=CE=D1 2011 =C7. 7:30 =D0=CF=CC=D8=DA=CF=D7=C1=D4=C5=CC=D8 Alexey =
Dokuchaev <danfe@freebsd.org>=CE=C1=D0=C9=D3=C1=CC:

> On Wed, Jun 22, 2011 at 11:39:54PM +0400, Ilya A. Arkhipov wrote:
> > Hi danfe@
> >
> > http://micro.heavennet.ru/ports/portlint/portlint.patch
> > please see it?
>
> thanks, seems to work fine.  I've beautified it a bit (see attach; sectio=
ns
> become badly numbered and some whitespace nits).  marcus@ is CCed.
>
> I'm not sure if we need to check/enforce any specific order of auxiliarly
> LICENSE_ knobs (LICENSE_PERMS, LICENSE_GROUPS, LICENSE_NAME, LICENSE_FILE=
,
> LICENSE_TEXT).
>
> ./danfe
>
Hi danfe@ marcus@

if I've got it right for group we need have specific order

+	&checkorder('LICENSE', $tmp, $file, qw(
+LICENSE LICENSE_COMB LICENSE_PERMS LICENSE_GROUPS
+LICENSE_NAME LICENSE_FILE LICENSE_TEXT+	));
what you say if we do that?



--=20
Best regards.
Ilya A. Arkhipov