From owner-freebsd-ports-bugs@FreeBSD.ORG Sun May 11 15:51:36 2003 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3333737B401 for ; Sun, 11 May 2003 15:51:36 -0700 (PDT) Received: from outpost.globcon.net (outpost.globcon.net [62.141.88.161]) by mx1.FreeBSD.org (Postfix) with SMTP id 2B94943FB1 for ; Sun, 11 May 2003 15:51:34 -0700 (PDT) (envelope-from sergei@kolobov.com) Received: (qmail 58658 invoked from network); 11 May 2003 22:51:36 -0000 Received: from h166.lukarcos.com (HELO kolobov.com) (62.141.88.166) by outpost.globcon.net with SMTP; 11 May 2003 22:51:36 -0000 Received: (qmail 7592 invoked by uid 911); 11 May 2003 22:51:16 -0000 Date: Mon, 12 May 2003 02:51:16 +0400 From: Sergei Kolobov To: Pete Fritchman , freebsd-ports-bugs@FreeBSD.org Message-ID: <20030511225116.GC697@globcon.net> Mail-Followup-To: Pete Fritchman , freebsd-ports-bugs@FreeBSD.org References: <200305101248.h4ACmZTJ041689@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200305101248.h4ACmZTJ041689@freefall.freebsd.org> User-Agent: Mutt/1.5.3i Subject: Re: ports/51815: [NEW PORT] devel/libdjbdns: Public domain DNS client library X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 May 2003 22:51:36 -0000 On 2003-05-10 at 07:48 -0500, Pete Fritchman wrote: > What do you think about installing the includes to > ${PREFIX}/include/djbdns? Their names are pretty general, conflict with > some system includes, and already conflict with another port (bglibs). I have envisioned resolving conflicts by allowing user to override LIBDJBDNS_ROOT variable (defaulting to PREFIX), but your suggestion makes more sense and avoids violating POLA. One minor change, though - IMHO, the port should install its include files into ${PREFIX}/include/libdjbdns, so a) it has clearer connection to the port's name and b) avoids any possible confusion regarding whether those files are installed by devel/libdjbdns or net/djbdns ports. Here is the diff from the original shar: (corresponding followup to ports/51814 will be submitted shortly) diff -ruN libdjbdns.orig/Makefile libdjbdns/Makefile --- libdjbdns.orig/Makefile Mon May 12 02:35:04 2003 +++ libdjbdns/Makefile Mon May 12 02:37:26 2003 @@ -18,8 +18,6 @@ USE_GMAKE= yes ALL_TARGET= it -LIBDJBDNS_ROOT?= ${PREFIX} - LIBS= libdjbdns.a libdjbdns.so.1 INCLUDES= alloc.h byte.h case.h dns.h env.h error.h fmt.h \ gen_alloc.h gen_allocdefs.h iopause.h ip4.h ndelay.h \ @@ -28,8 +26,9 @@ uint32.h uint64.h do-install: + @${MKDIR} ${PREFIX}/include/libdjbdns cd ${WRKSRC} && \ - ${INSTALL_DATA} ${LIBS} ${LIBDJBDNS_ROOT}/lib && \ - ${INSTALL_DATA} ${INCLUDES} ${LIBDJBDNS_ROOT}/include + ${INSTALL_DATA} ${LIBS} ${PREFIX}/lib && \ + ${INSTALL_DATA} ${INCLUDES} ${PREFIX}/include/libdjbdns .include diff -ruN libdjbdns.orig/pkg-plist libdjbdns/pkg-plist --- libdjbdns.orig/pkg-plist Mon May 12 02:35:04 2003 +++ libdjbdns/pkg-plist Mon May 12 02:36:28 2003 @@ -1,27 +1,27 @@ -include/alloc.h -include/byte.h -include/case.h -include/dns.h -include/env.h -include/error.h -include/fmt.h -include/gen_alloc.h -include/gen_allocdefs.h -include/iopause.h -include/ip4.h -include/ndelay.h -include/open.h -include/openreadclose.h -include/readclose.h -include/scan.h -include/select.h -include/socket.h -include/str.h -include/stralloc.h -include/tai.h -include/taia.h -include/uint16.h -include/uint32.h -include/uint64.h +include/libdjbdns/alloc.h +include/libdjbdns/byte.h +include/libdjbdns/case.h +include/libdjbdns/dns.h +include/libdjbdns/env.h +include/libdjbdns/error.h +include/libdjbdns/fmt.h +include/libdjbdns/gen_alloc.h +include/libdjbdns/gen_allocdefs.h +include/libdjbdns/iopause.h +include/libdjbdns/ip4.h +include/libdjbdns/ndelay.h +include/libdjbdns/open.h +include/libdjbdns/openreadclose.h +include/libdjbdns/readclose.h +include/libdjbdns/scan.h +include/libdjbdns/select.h +include/libdjbdns/socket.h +include/libdjbdns/str.h +include/libdjbdns/stralloc.h +include/libdjbdns/tai.h +include/libdjbdns/taia.h +include/libdjbdns/uint16.h +include/libdjbdns/uint32.h +include/libdjbdns/uint64.h lib/libdjbdns.a lib/libdjbdns.so.1