From owner-freebsd-bugs@FreeBSD.ORG Mon Apr 7 08:20:01 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7AF83106566C for ; Mon, 7 Apr 2008 08:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4F81B8FC1B for ; Mon, 7 Apr 2008 08:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m378K1XB035246 for ; Mon, 7 Apr 2008 08:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m378K1JU035245; Mon, 7 Apr 2008 08:20:01 GMT (envelope-from gnats) Resent-Date: Mon, 7 Apr 2008 08:20:01 GMT Resent-Message-Id: <200804070820.m378K1JU035245@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Peter Much Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F39D6106564A for ; Mon, 7 Apr 2008 08:13:22 +0000 (UTC) (envelope-from pmc@citylink.dinoex.sub.org) Received: from uucp.dinoex.sub.de (uucp.dinoex.sub.de [194.45.71.2]) by mx1.freebsd.org (Postfix) with ESMTP id 491548FC1E for ; Mon, 7 Apr 2008 08:13:21 +0000 (UTC) (envelope-from pmc@citylink.dinoex.sub.org) Received: from uucp.dinoex.sub.de (uucp@uucp.dinoex.sub.de [194.45.71.2] (may be forged)) by uucp.dinoex.sub.de (8.14.2/8.14.2) with ESMTP id m378DA3A043224 for ; Mon, 7 Apr 2008 10:13:11 +0200 (CEST) (envelope-from pmc@citylink.dinoex.sub.org) Received: from citylink.dinoex.sub.org (uucp@localhost) by uucp.dinoex.sub.de (8.14.2/8.14.2/Submit) with UUCP id m378DAKO043223 for FreeBSD-gnats-submit@freebsd.org; Mon, 7 Apr 2008 10:13:10 +0200 (CEST) (envelope-from pmc@citylink.dinoex.sub.org) Received: from gate.oper.dinoex.org (gate-e [192.168.98.2]) by citylink.dinoex.sub.de (8.14.2/8.14.2) with ESMTP id m377sJSJ069579 for ; Mon, 7 Apr 2008 09:54:19 +0200 (CEST) (envelope-from peter@gate.oper.dinoex.org) Received: from gate.oper.dinoex.org (gate-e [192.168.98.2]) by gate.oper.dinoex.org (8.14.2/8.14.2) with ESMTP id m377qhXU069404 for ; Mon, 7 Apr 2008 09:52:43 +0200 (CEST) (envelope-from peter@gate.oper.dinoex.org) Received: (from peter@localhost) by gate.oper.dinoex.org (8.14.2/8.14.2/Submit) id m377qh74069403; Mon, 7 Apr 2008 09:52:43 +0200 (CEST) (envelope-from peter) Message-Id: <200804070752.m377qh74069403@gate.oper.dinoex.org> Date: Mon, 7 Apr 2008 09:52:43 +0200 (CEST) From: Peter Much To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/122519: ppp provides deficient DNS info X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Peter Much List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Apr 2008 08:20:01 -0000 >Number: 122519 >Category: bin >Synopsis: ppp provides deficient DNS info >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Apr 07 08:20:00 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Peter Much >Release: FreeBSD 6.3-RELEASE-p1 i386 >Organization: n/a >Environment: System: FreeBSD edge.oper.dinoex.org 6.3-RELEASE-p1 FreeBSD 6.3-RELEASE-p1 #9: Sat Apr 5 05:37:18 CEST 2008 root@:/usr/src/sys/i386/compile/E1R63V1 i386 nothing special needed >Description: ppp, in server-side operation, is supposed to provide 2 DNS adresses to the calling client. And it should fetch these out of /etc/resolv.conf. In fact, it provides only one of these: the second one. This could even be considered serious because, depending on their connectivity, it may cost people real money to persistently connect their second, fall-back nameserver, and they may not notice it too soon. >How-To-Repeat: * configure at least 2 nameservers in your resolv.conf * configure your ppp to log IPCP negotiations and to "accept dns" (that means actually that the ppp will accept requests for nameserver adresses). * bring up a connection and let the connecting peer ask for DNS info. * read the logfile. >Fix: --- usr.sbin/ppp/ipcp.c.orig 2008-04-07 08:44:44.000000000 +0200 +++ usr.sbin/ppp/ipcp.c 2008-04-07 08:47:19.000000000 +0200 @@ -247,7 +247,7 @@ ch = *ncp; *ncp = '\0'; - if (n < 2 && inet_aton(cp, ipcp->ns.dns)) + if (n < 2 && inet_aton(cp, (ipcp->ns.dns)+n)) n++; *ncp = ch; >Release-Note: >Audit-Trail: >Unformatted: