From owner-freebsd-ports@freebsd.org Mon Mar 21 14:35:56 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B961DAD805D for ; Mon, 21 Mar 2016 14:35:56 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A1D09A2C for ; Mon, 21 Mar 2016 14:35:56 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 9D984AD805C; Mon, 21 Mar 2016 14:35:56 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9CE33AD805B for ; Mon, 21 Mar 2016 14:35:56 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 52778A2B; Mon, 21 Mar 2016 14:35:55 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 776E4BDCAD; Mon, 21 Mar 2016 15:35:54 +0100 (CET) Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gw.in.absolight.net", Issuer "CA Cert Signing Authority" (not verified)) by prod2.absolight.net (Postfix) with ESMTPSA id 369FCBDCA6; Mon, 21 Mar 2016 15:35:54 +0100 (CET) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) by gw.in.absolight.net (Postfix) with ESMTP id B07E6614B; Mon, 21 Mar 2016 15:35:53 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by ogg.in.absolight.net (Postfix) with ESMTP id 65C732140878; Mon, 21 Mar 2016 15:35:53 +0100 (CET) Date: Mon, 21 Mar 2016 15:35:52 +0100 From: Mathieu Arnold To: Don Lewis , ports@FreeBSD.org Subject: Re: gnome-post-install ordering Message-ID: <8EB21981928900BCB811B4B1@ogg.in.absolight.net> In-Reply-To: <201603161757.u2GHvsbJ038871@gw.catspoiler.org> References: <201603161757.u2GHvsbJ038871@gw.catspoiler.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="==========B3C56815D48710D83669==========" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 14:35:56 -0000 --==========B3C56815D48710D83669========== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline +--On 16 mars 2016 10:57:54 -0700 Don Lewis wrote: | I'm trying to debug why gtk-update-icon-cache isn't getting run when | the OpenOffice package is installed and ran into something that I don't | understand. | | The Makefile contains INSTALLS_ICONS=yes, which has the side effect of | setting USES+=gnome, USE_GNOME+=gtk-update-icon-cache, and | _USES_install+=690:gnome-post-install, and that target is responsible | for parsing ${TMPPLIST} and invoking gtk-update-icon-cache as needed. | I do see gtk-update-icon-cache in the dependency list in +MANIFEST, so | it appears that INSTALLS_ICONS=yes is being detected. | | It appears that things go wrong because I'm using the Makefile | post-install target to generate the plist. If I look at bsd.port.mk, I | see that _STAGE_SEQ contains 700:post-install. It looks to me like | gnome-post-install is getting run before the plist is generated, which | would explain why gnome-post-install isn't detecting any icons and not | invoking gtk-update-icon-cache. | | Why is gnome-post-install earlier than post-install, which at least some | ports use to do plist generation? Some ports do plist generation in | do-install, but that doesn't work if there are do-install option helpers | because those get run after the main do-install target. | | There is the TARGET_ORDER_OVERRIDE knob, but it is very lightly used. It is there exactly for the problem you have, change the order targets are run for one port. And it is very lightly used because it's only needed when you do some strange things that nobody else does ;-) For example, I just added it to devel/p5-ReadLine-TTYtter because I needed to run post-install before fix-perl-things. And it was ok to do it because it's a somewhat unique case. So, basically, you need to put: TARGET_ORDER_OVERRIDE= 650:post-install so that it's ran before gnome-post-install, and you're set. Now, I don't have a problem with moving gnome-post-install after post-install (like, 710), which would also fix your problem, but it will need an exp-run to make sure nothing breaks. -- Mathieu Arnold --==========B3C56815D48710D83669========== Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJW8AbJXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IpuoQALwFZ3vqkxvHehVpJTveEYQw f35th4ivW7CPCGqF+k4bX/5JLiAOJEqFjjOUssVgJQ1sg3NLDukPihwsAvlawrVn t4D3ot6LED2DuB/7GactoBVKgK4RGNI4Xhwofp4jkNU3h41k93z12FMGx+9Pp+3d gAsBP/zCLlOLjPy0Zx95mArQlnfk4r+84AewvI2jyRsfKpp6xr7UTPXZrnbvQGTk WuyzmerK45Vd+pzUho9UlV8/TNRzxBcbiyT7j+tWpy4BROO9J1u04Bu9Ri8LdZDp fk6dq8BNT2Gy8hp9SafremKgxri76nXdjEUOwGytwxMCYGRDP8gSas3LmFFRuWDq 0lNaq5hI+Bhd/4rsVQ1Friv7Fm3BQVjyFyemMmbdHI7lwXK13Q+Ab/X3Ttj/PwK7 x4T7iApdXW2UVaLlTmLoeBhpeRtZdQ2yUa3En8M5v2FITjMiEyWmijsz5fC5KZnb ASDdJZ9eLBsasFYNcA9Li7WKF8XcBoO9guIs8pbNf5qm1U/aKwWnWfuYSY5pX4LM NZO49Dg7UBpm+MYbk7vKx2gMfOkgLGY/HOmZK9LnBpdC8jPvb3UN5NRjs2nP4m+h VKWwwlonLf7WJSCKfk0qG01eXFldOhRzGZ1E4VwjVY7jG735fm8jO4Tkxbha0plq l088g7N/97L0+h+CIBMN =gwWy -----END PGP SIGNATURE----- --==========B3C56815D48710D83669==========--