From owner-svn-src-all@FreeBSD.ORG  Mon Sep 13 12:08:47 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DF29F1065670;
	Mon, 13 Sep 2010 12:08:47 +0000 (UTC) (envelope-from avg@freebsd.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 91D0C8FC08;
	Mon, 13 Sep 2010 12:08:46 +0000 (UTC)
Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA18190;
	Mon, 13 Sep 2010 15:08:45 +0300 (EEST)
	(envelope-from avg@freebsd.org)
Received: from localhost.topspin.kiev.ua ([127.0.0.1])
	by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1Ov7q0-000J3p-Rl; Mon, 13 Sep 2010 15:08:44 +0300
Message-ID: <4C8E144C.3030405@freebsd.org>
Date: Mon, 13 Sep 2010 15:08:44 +0300
From: Andriy Gapon <avg@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.9) Gecko/20100912 Lightning/1.0b2 Thunderbird/3.1.3
MIME-Version: 1.0
To: "Jayachandran C." <jchandra@freebsd.org>
References: <201009131147.o8DBla8x095589@svn.freebsd.org>
In-Reply-To: <201009131147.o8DBla8x095589@svn.freebsd.org>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r212550 - head/sys/mips/rmi
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Sep 2010 12:08:48 -0000

on 13/09/2010 14:47 Jayachandran C. said the following:
> Author: jchandra
> Date: Mon Sep 13 11:47:35 2010
> New Revision: 212550
> URL: http://svn.freebsd.org/changeset/base/212550
> 
> Log:
>   bus_add_child method is needed now.

Just a note: bus_add_child method needs to be defined only if it's actually
used, i.e. a device/bus has at least one child that calls BUS_ADD_CHILD.

> Modified:
>   head/sys/mips/rmi/iodi.c
> 
> Modified: head/sys/mips/rmi/iodi.c
> ==============================================================================
> --- head/sys/mips/rmi/iodi.c	Mon Sep 13 09:51:24 2010	(r212549)
> +++ head/sys/mips/rmi/iodi.c	Mon Sep 13 11:47:35 2010	(r212550)
> @@ -305,6 +305,7 @@ static device_method_t iodi_methods[] = 
>  	DEVMETHOD(device_identify, iodi_identify),
>  	DEVMETHOD(bus_alloc_resource, iodi_alloc_resource),
>  	DEVMETHOD(bus_activate_resource, iodi_activate_resource),
> +	DEVMETHOD(bus_add_child, bus_generic_add_child),
>  	DEVMETHOD(bus_setup_intr, iodi_setup_intr),
>  	{0, 0},
>  };


-- 
Andriy Gapon