From owner-svn-src-head@freebsd.org Tue Jan 22 18:01:30 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 958B714AA076 for ; Tue, 22 Jan 2019 18:01:30 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1A7489667E for ; Tue, 22 Jan 2019 18:01:30 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1548179061; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=oOUBlm9JajN7+0ZEEUbG11uudqQM4GyzgST3k2TCV4TqSG6iaGsUce3MiGtYq5FW1VO+R3/yuo/CH /TjFZbDdhx1tnsMHeoTAkhMZiMuEG6EV53lfErTPZvN5JPIj0ZbCwWckRrBXnVShrA3xDIhztL81fL AJjwRA8i9E12Mrf0N6QW8NOQoYSOqGn+Mqc6OxWD6melk4xmAoPcF5C0FXyYu9dx81TfKv7lD7dBG5 ErkhyyaoeEs50Sr9VypOnRdEGZQwFKKruyoOimXXX1Pth8cyfdgMnkabBXoFDnP4umsQmKOTA1pnDb MrwDukxPUeXxSCUdofneO8yfhyouePg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=y8SE+s26+b5A4cv8r00QVFwFf9GBwxNXwW/UBadoJSo=; b=NIq8YKZaObY1Cudb/12cbj7vSSeWSoVCpDJtmWzMme3nApEzqR2sjG7pAaydBrgWEBRg+AuUvOxks rT29z5NMcK9PErMKKN70HT9s8kaPzTUmzqAZi72CBhJ3HoLG6lmeRTLO9NG137J6jqn9U1tSlij4nY xHKResICkGcQAIheg1ipec8SRiIL/iAWrty2dMtiUK23a6JqcGYLQLE2EnocYU6h52VbommzZq2rQW qExWtnO1HULkggD35j1y6nUzGlAysd+d02gymCAxD7Rr6sKJBGmHecJFQCe3C7iKk1qhWg/f6iQYNr kXQR7mZBysb+6YOyVG3KFso+5Pvj7BA== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=y8SE+s26+b5A4cv8r00QVFwFf9GBwxNXwW/UBadoJSo=; b=ImYpBIqc+Cmgc4L5cjoVg424ZDb7R17/J4TFHRVIc9m0ylyTi/NI6sjoa6GpTXYLWZ+wSx0ScU26S PzgXIrFJFw+V20NmQYF0J0WaHvnx2OQdNRfzbMvAfGKJNlrTKGLjUpXN13/OemcIrZTZ3fNBgsFbO8 qk7sK8YXgJvHIhItCKYTAgT1IEutrJ/KjD8Rboi0ZvwlqvysPNZwlGPWE1klAyPNXZDZRtTg5Mnj6f YSbZeJNHrC+SSer3qT0O6/b8nQ+R2cCLwrU+d3IxES3aapXr2XXkQbY7DpmvpuN0at4eFucGUl7nSa t/f0ZkjUI3dN6jpDgUpgxrT4L08REtA== X-MHO-RoutePath: aGlwcGll X-MHO-User: 588bbae1-1e6d-11e9-befd-af03bedce89f X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 588bbae1-1e6d-11e9-befd-af03bedce89f; Tue, 22 Jan 2019 17:44:20 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x0MHjGPH095249; Tue, 22 Jan 2019 10:45:16 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r343305 - head/sys/net From: Ian Lepore To: Brooks Davis , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 22 Jan 2019 10:45:16 -0700 In-Reply-To: <201901221739.x0MHdQps047360@repo.freebsd.org> References: <201901221739.x0MHdQps047360@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1A7489667E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2019 18:01:30 -0000 On Tue, 2019-01-22 at 17:39 +0000, Brooks Davis wrote: > Author: brooks > Date: Tue Jan 22 17:39:26 2019 > New Revision: 343305 > URL: https://svnweb.freebsd.org/changeset/base/343305 > > Log: > Rework CASE_IOC_IFGROUPREQ() to require a case before the macro. > > This is more compatible with formatting tools and looks more > normal. > > Reported by: jhb (on a different review) > Sponsored by: DARPA, AFRL > Differential Revision: https://reviews.freebsd.org/D18442 > > Modified: > head/sys/net/if.c > > Modified: head/sys/net/if.c > ===================================================================== > ========= > --- head/sys/net/if.c Tue Jan 22 17:34:53 2019 (r343304) > +++ head/sys/net/if.c Tue Jan 22 17:39:26 2019 (r343305) > @@ -168,14 +168,14 @@ struct ifmediareq32 { > #define SIOCGIFXMEDIA32 _IOC_NEWTYPE(SIOCGIFXMEDIA, struct > ifmediareq32) > > #define _CASE_IOC_IFGROUPREQ_32(cmd) > \ > - case _IOC_NEWTYPE((cmd), struct ifgroupreq32): > + _IOC_NEWTYPE((cmd), struct ifgroupreq32): case That 'case' at the end of the line doesn't look right. -- Ian