Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 Jan 2014 09:04:25 +0100
From:      Pietro Cerutti <gahr@FreeBSD.org>
To:        Lars Engels <lme@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r339185 - head/Tools/scripts
Message-ID:  <20140109080425.GI8627@gahrfit.gahr.ch>
In-Reply-To: <201401082243.s08MhLsI004002@svn.freebsd.org>
References:  <201401082243.s08MhLsI004002@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--yzvKDKJiLNESc64M
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2014-Jan-08, 22:43, Lars Engels wrote:
> Author: lme
> Date: Wed Jan  8 22:43:21 2014
> New Revision: 339185
> URL: http://svnweb.freebsd.org/changeset/ports/339185
>=20
> Log:
>   - Allow a leading "r" in the svn revision
>   - Use a variable for the Subversion server
>   - Consistently use ${} around variables
>   - Bail out if neither svn(1) nor svnlite(1) are installed
>  =20
>   Approved by:	bapt
>=20
> Modified:
>   head/Tools/scripts/mfh   (contents, props changed)
>=20
> Modified: head/Tools/scripts/mfh
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/Tools/scripts/mfh	Wed Jan  8 22:34:40 2014	(r339184)
> +++ head/Tools/scripts/mfh	Wed Jan  8 22:43:21 2014	(r339185)
> @@ -53,35 +53,47 @@ ask() {
> =20
>  [ $# -ne 2 ] && err "Takes 2 arguments: <branch> <revnumber>"
>  branch=3D$1
> -rev=3D$2
> -case $rev in
> +rev=3D${2##r} # remove a leading "r"
> +case ${rev} in
>  ''|*[!0-9]*) err "revision should be a number" ;;
>  esac
> =20
> +svnserver=3D"svn.FreeBSD.org"
> +
> +if [ -n "$(type svn 2>/dev/null)" ]; then
> +	svn=3Dsvn
> +elif [ -n "$(type svnlite 2>/dev/null)" ]; then
> +	svn=3Dsvnlite
> +else
> +	err "svn(1) and svnlite(1) not found. please install devel/subversion"
> +fi
> +
> +
>  dir=3D$(mktemp -d /tmp/merge.XXX)
> -cd $dir
> -svn co --depth=3Dempty svn+ssh://svn.FreeBSD.org/ports/branches/${branch}
> +cd ${dir}
> +${svn} co --depth=3Dempty svn+ssh://${svnserver}/ports/branches/${branch}
>  filelist=3D""
> -for f in $(svn diff --summarize -c $rev svn://svn.FreeBSD.org/ports/head=
); do
> +# svn:// is faster than svn+ssh://. Use it wherever it's possible.
> +for f in $(${svn} diff --summarize -c ${rev} svn://${svnserver}/ports/he=
ad); do

Would you mind switching to svn+ssh everywhere? The thing is, if you're
going to merge, you'll be using svn+ssh anyway, and it might be the case
that plain svn is not available because of some stupid firewall rules -
which is exactly my case and the reason for my asking.

Thanks,

--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp

--yzvKDKJiLNESc64M
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQJ8BAEBCgBmBQJSzlgFXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQTZERTEwNkE1Qjg1NEI4NUREODZENDlB
REQwRDM4RUExOTIwODlFAAoJEK3Q046hkgieuzgQAJHtjqb3DgzqpNkQd6aMLviU
gtKLyK89qzgsvh9amuPTuLBx1TWKH+c5IHrCHA8mrg7t52hgWwCSSwrxhg12SzV3
crcoIXmL65qNCMaLHqVVINyYjPCuYh0hx/0j1OEMZ0Ret0T1HiLgUorUnTn/Ak6d
bxNIhyEc9XKaqM0UPKylHlaQwozOSOZjK31eyS9xDIA/YjFp2SCl5wc+czj1RRKd
/QN1VHXOt2DlLGeB+IYJF/ONLYuLsqiNyGFhHi8V2uf6+/bOtqglVNSoyuKo6Duc
zlJBXIkTuzPBlfwxEp9J3/9luDgMPbgPNh+nfJwM4M520tbw85DHIzoqyCt3bH3T
vHNfoTZmgVDmgvxad4WsPwipFIesMr3KBPn6snBnCgLbP1WlMVUUI9Lw8zbOdI6U
YEUOXiAig8/guPOPgiT9HXO0kiyXzNMOxnflyUQa1h98tVX3nsbITRcK7BT3YAuj
mR8wUPdKjY29lonXXv9rKCYC9JtZlD59Nv3mKyGH7g5FNEMTaD6lNtarXfqiTH/s
BVz8DhgMGjnmqlZPxLqJb0fSj9cuQ0z9VhMCSKhSHI5/JB2APnnF3tN5aLrrLFwl
oQRmPFQ8frSu59GTpv268HPT6nhhr85/O5n8uu8QugcRYigCK0fvrqNEu2/yb+ja
lU9/s/5ai71d7YN5oYAa
=mbDI
-----END PGP SIGNATURE-----

--yzvKDKJiLNESc64M--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140109080425.GI8627>