Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 27 Oct 2001 12:02:04 -0700
From:      Terry Lambert <tlambert2@mindspring.com>
To:        Luigi Rizzo <rizzo@aciri.org>
Cc:        Mike Silbersack <silby@silby.com>, Alfred Perlstein <bright@mu.org>, Soren Kristensen <soren@soekris.com>, net@FreeBSD.ORG
Subject:   Re: NEW CODE: polling support for device drivers.
Message-ID:  <3BDB04AC.1D100774@mindspring.com>
References:  <20011027035240.Q15052@elvis.mu.org> <20011027044854.X88536-100000@achilles.silby.com> <20011027080448.F77729@iguana.aciri.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Luigi Rizzo wrote:
> 
> On Sat, Oct 27, 2001 at 04:52:54AM -0500, Mike Silbersack wrote:
> ...
> > Summary:  The patch Terry posted was to loop a few more times in the
> > interrupt handler.  I was going to commit it this weekend for the dc
> > driver, but it looks like Luigi's work overshadows that.
> 
> Terry was kind enough to send me a copy of his patch. I havent
> looked at it in much details, but from what i remember it
> matches the description given above by Mike, and is totally
> different from what I have done (which also explain why i did not
> look more closely at Terry's code).

Yes.  The code is totally complementary.

> Note, the use of polling is not novel and i do not claim any
> paternity on the ideas i have implemented -- polling has been
> largely described in the literature and implemented by some (I know
> of Mogul's 1997 paper on preventing interrupt livelock and of MIT's
> Click http://www.pdos.lcs.mit.edu/Click/ ).

Yes, the Click router project (no relation to ClickArray) is
a nifty piece of work.  It has too much overengineering for
modularity, for my taste, in that the latency is taken at
run time, instead of module assembly time.

I've been pointing at the 1991 Mogul paper, myself, on the
coelescing defense front.  The guy is incredibly prolific!  8-).

> I am just quite proud of how simple and compact (and possibly
> elegant) this code came out (admittedly, this is the third
> rewrite!)

Yes, it's very nice code.  I like it.

Note to FreeBSD people: you would do well to incorporate code
from Luigi whenever possible.  You would have had a SACK and
TSACK implementation for FreeBSD Circa 1996 or so, about half
a decade before any commercial OS had it.  The TSACK, in
particular, did not rely on Microsoft implementing SACK in
their clients, which is what everyone else held off their
implementations over.

-- Terry

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3BDB04AC.1D100774>