From owner-freebsd-toolchain@FreeBSD.ORG  Mon Apr 13 16:18:29 2015
Return-Path: <owner-freebsd-toolchain@FreeBSD.ORG>
Delivered-To: freebsd-toolchain@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 648DC8B5
 for <freebsd-toolchain@freebsd.org>; Mon, 13 Apr 2015 16:18:29 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 461CC97
 for <freebsd-toolchain@freebsd.org>; Mon, 13 Apr 2015 16:18:29 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t3DGITwO086406
 for <freebsd-toolchain@freebsd.org>; Mon, 13 Apr 2015 16:18:29 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3DGITMj086405;
 Mon, 13 Apr 2015 16:18:29 GMT (envelope-from root)
Date: Mon, 13 Apr 2015 16:18:28 +0000
To: freebsd-toolchain@freebsd.org
From: "jmg (John-Mark Gurney)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Updated] D2285: gcc 4.9.1 compilation fixes for aesni
Message-ID: <458b091c8dbb6507c11d4dbffed2a6d2@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2285: gcc 4.9.1 compilation fixes for aesni
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-2q5asccazp7ohcpzdm6o>
X-Phabricator-To: <PHID-USER-hczvtoiiwwmjh7l2sjsg>
X-Phabricator-Cc: <PHID-MLST-i5ptaleg3lqtvx7cknno>
In-Reply-To: <differential-rev-PHID-DREV-tbuu2z6eg4ufbwz5eu2l-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-tbuu2z6eg4ufbwz5eu2l-req@FreeBSD.org>
Thread-Index: MmIyNDI1MWVlZGY5MTMzMjJkZjYzZDBmNzhmIFUr7FQ=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-reviewers>, <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Maintenance of FreeBSD's integrated toolchain
 <freebsd-toolchain.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain/>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Apr 2015 16:18:29 -0000

jmg added a comment.

hmm.. maybe we should put this hack into a different header file and just include that one…  since all these files are in crypto/aesni, why not a local header (use quotes) that is named gnuhack.h or something (can't think of a good name right now)?

Right now it's only three files, but I have work that may expand the number of files that this hack is required to be added too, and if we need to add hacks for other compilers, or if gnu changes how things are, then we can update the hacks in one location, instead of n locations.

REVISION DETAIL
  https://reviews.freebsd.org/D2285

To: rodrigc, jmg
Cc: freebsd-toolchain