From owner-p4-projects@FreeBSD.ORG Wed Sep 12 22:40:02 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3552F16A420; Wed, 12 Sep 2007 22:40:02 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3FF616A417; Wed, 12 Sep 2007 22:40:01 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id 7C23213C458; Wed, 12 Sep 2007 22:40:01 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id A80FD45E9D; Thu, 13 Sep 2007 00:39:59 +0200 (CEST) Received: from localhost (154.81.datacomsa.pl [195.34.81.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 48CD745E98; Thu, 13 Sep 2007 00:39:54 +0200 (CEST) Date: Thu, 13 Sep 2007 00:38:33 +0200 From: Pawel Jakub Dawidek To: Attilio Rao Message-ID: <20070912223833.GC4909@garage.freebsd.pl> References: <200709120832.l8C8WLlm085731@repoman.freebsd.org> <20070912150017.GA3553@garage.freebsd.pl> <3bbf2fe10709121530h6d0681c4xa247fe7d31cb2c2e@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gr/z0/N6AeWAPJVB" Content-Disposition: inline In-Reply-To: <3bbf2fe10709121530h6d0681c4xa247fe7d31cb2c2e@mail.gmail.com> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: Kip Macy , Perforce Change Reviews , Kip Macy Subject: Re: PERFORCE change 126330 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2007 22:40:02 -0000 --gr/z0/N6AeWAPJVB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 13, 2007 at 12:30:26AM +0200, Attilio Rao wrote: > 2007/9/12, Kip Macy : > > On 9/12/07, Pawel Jakub Dawidek wrote: > > > On Wed, Sep 12, 2007 at 08:32:21AM +0000, Kip Macy wrote: > > > > http://perforce.freebsd.org/chv.cgi?CH=3D126330 > > > > > > > > Change 126330 by kmacy@kmacy_home:ethng on 2007/09/12 08:31:36 > > > > > > > > convert radix node head and route locks from mutexes to rwloc= ks > > > [...] > > > > rt->rt_flags |=3D RTF_LLINFO; > > > > - callout_init_mtx(&la->la_timer, &rt->rt_mtx, > > > > - CALLOUT_RETURNUNLOCKED); > > > > + callout_init_rwlock(&la->la_timer, &rt->rt_lock, > > > > + CALLOUT_RETURNUNLOCKED_RW); > > > > > > > > > > Kip, don't add callout_init_rwlock() to the tree. I've > > > callout_init_lock() implemented that operates on any lock type, just > > > like condvar(9). > > > > point me to a diff >=20 > I'm courious to know another thing instead. > As like condvar() works, it is allowed to before release and later > acquire the lock. > This scheme let you acquire the lock again following the previous > pattern for sx and rw locks (if for example you had a rwlock mantained > in write mode you will acquire it in the same way). > This is not applicable to callout, instead, as you have the lock > 'blank', so with double-kind locks (like rw and sx) how do you lock > it? Always write/exclusive. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --gr/z0/N6AeWAPJVB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFG6GppForvXbEpPzQRAiM5AJ9DwE4JoHnAeh+AVXCmlHdS8Vp1GwCdH266 SsJa32UH5SrW0eppocvkupY= =dyqW -----END PGP SIGNATURE----- --gr/z0/N6AeWAPJVB--