From owner-svn-src-stable-11@freebsd.org Wed Aug 15 17:30:42 2018 Return-Path: Delivered-To: svn-src-stable-11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 482091069A98; Wed, 15 Aug 2018 17:30:42 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D086A97E49; Wed, 15 Aug 2018 17:30:41 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 467FB1616D; Wed, 15 Aug 2018 17:30:41 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf1-f46.google.com with SMTP id 95-v6so1418121lfy.9; Wed, 15 Aug 2018 10:30:41 -0700 (PDT) X-Gm-Message-State: AOUpUlH+05n3ddHqgVwHMARU9Bi9O31reL//A/eG36TaThYNq/tl2exL Xo4bZLNkSzoT9FSqQHd64crfaI0q0s802x7aZpU= X-Google-Smtp-Source: AA+uWPzxZD71hIrozGdI6D1f3XSIy2S52ei/VnNsXBT0LlMh/XK3XuuFtli/pNrs4xuhb/mslD2akplzC51uQXnYYMs= X-Received: by 2002:a19:26d2:: with SMTP id m201-v6mr16556099lfm.43.1534354238962; Wed, 15 Aug 2018 10:30:38 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:5742:0:0:0:0:0 with HTTP; Wed, 15 Aug 2018 10:30:18 -0700 (PDT) In-Reply-To: <201808151607.w7FG7Smo048317@pdx.rh.CN85.dnsmgr.net> References: <201808151607.w7FG7Smo048317@pdx.rh.CN85.dnsmgr.net> From: Kyle Evans Date: Wed, 15 Aug 2018 12:30:18 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r337826 - stable/11/bin/ls To: "Rodney W. Grimes" Cc: Ed Maste , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-stable-11@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for only the 11-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 17:30:42 -0000 On Wed, Aug 15, 2018 at 11:07 AM, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> On 14 August 2018 at 21:41, Rodney W. Grimes >> wrote: >> >> Author: kevans >> >> Date: Wed Aug 15 01:29:02 2018 >> >> New Revision: 337826 >> >> URL: https://svnweb.freebsd.org/changeset/base/337826 >> >> >> >> Log: >> >> MFC r337506: ls(1): Enable colors with COLORTERM is set in the environment >> >> >> >> COLORTERM is the de facto standard, while CLICOLOR is generally specific to >> >> FreeBSD and ls(1). >> > >> > I have already seen one "Who enabled %&*@(#$@) colored ls output in 12?" >> > Seems that the defaults for xfce terminal is to have COLORTERM. >> >> If xfce's default is to request colour via the de-facto environment >> variable then we should generally honour it -- the answer to the >> %&*@(#$@) question is "you did, via your terminal's default." > > And I pointed that out to them, but it is kinda a POLA, people have > had to take explicit action to get colorls, that is no longer true > and that suprises them when they see it. > I find the POLA angle kind-of hard to buy, though. Nothing in the base system offers a way for the default behavior of ls(1) to be altered, and this whole change is only honoring a de-facto standard for indicating that a colored terminal is supported and desired. IMO, one should be aware of how the software they use is affecting their environment and the kinds of repercussions these changes may have. This is hardly the first bit of software that respects COLORTERM, and it surely won't be the last (in general... no specific plans here). =(