From nobody Fri May 24 10:40:27 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vm1lg4kjWz5MCrW; Fri, 24 May 2024 10:40:31 +0000 (UTC) (envelope-from rnagy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vm1lg42s3z4Nwf; Fri, 24 May 2024 10:40:31 +0000 (UTC) (envelope-from rnagy@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716547231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9+a53FI2XLVyQntdl2U8sH9xjqAfinmB8UfKQvgxGjg=; b=Obe6uvQ2bCTlxTNnV1hQyerO38Kr0GI9nZPgA1pGy5DRRdJ/jRiCA5TnnJDJn4+16FsgoW Jd+8LN4fnTzjaKZAPzqUIYRM0mnEuP5JsIGKwy+gWnYLjkJnJ4U4vn+J0wFhCOzeNDtAVX fq9+iOLqEwwV9/7I2qEpSdKcEtmUI7UxnJe3aVeqUXSBYP3IYJ1a7jmwJZ9AdgM4lFSIRE 5BIjTqjQ+Lss5mjaZ2eFTNfKtHF9jn7yZO68/wGWSC7/8peRjalTYzel8AW1l70C515+/m 0+k3vNU23uhXpwlDfYn7m3MnJ52NK2sJMXE2GBafatAqFSS0/5kVlR1T2tZg0w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716547231; a=rsa-sha256; cv=none; b=Eh1KCodQD1CybG/3p3H5RjjonV9quq4xgOukhjgwq38WExm2bygBpV2f6ZjUwh+G1ZUrZS MS1221kpcq+S4UT/Ttj/tsbBCa3zTQ5A2+M8inPfHoG27Yrye+3Y3MiBfdNhRZf721UEjV iFXZgnwKf1OxdsQzyhEMtFeORrKltVfvrwDRSdgKEB7M6DZWsOcKxMBe7nRoHkKXzSwRgB hMMfgNwahyceeafkMC/SSScQ03oj8CLQcDiIcEeeZD4IBpQ4L8mGbq/5buoVzaDrdUsHsT 6NJxQrYOOG7tU2FXz0Y3H4i4H7hmd5alQZLE+jSB9s6LIrMYXi9TEaBzTG5PqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716547231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9+a53FI2XLVyQntdl2U8sH9xjqAfinmB8UfKQvgxGjg=; b=iLFP5rXnYlqpKFwuc272mTvD9hX/Km6M8rzRMPP7y6LD/l3iTFR7PTfKARa9r25xfm5izj 3mwzLZ3sMVJV7VMDEIG03giemJlEPvEUQCYmOYMcIJ+Vu8Eq0O1jdplo2u67iuF3lb/p+m Ine7P8cNLdKJXCkHo+a0DWY2t6ZtBKSMXrKtpZeEBDUCEX6Vuzer21Yuclbr6UpJAS63wO WMFtS10H6ED5+zR533OLjK8amy2GaXza6Uoaf0PJRbN+juLRF8ZoEPOW9A9Ig8a4iyPoDA /xY11AaDJT2bR37VV6YKWltN+zPWRueKbsUXiTkqoJ85r2n1Pu6ReCN2nRQe1A== Received: from freebsd.org (nerd.hu [84.2.34.134]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (Client did not present a certificate) (Authenticated sender: rnagy/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Vm1lf6slnzdr8; Fri, 24 May 2024 10:40:30 +0000 (UTC) (envelope-from rnagy@freebsd.org) Date: Fri, 24 May 2024 12:40:27 +0200 From: Robert Nagy To: Vladimir Druzenko Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b4d0a174c529 - main - www/ungoogled-chromium: update to 125.0.6422.76 and implement selectable audio backend support Message-ID: References: <202405240347.44O3le5k098915@gitrepo.freebsd.org> <857780ad-a8d7-4075-8468-8aba187897f4@freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <857780ad-a8d7-4075-8468-8aba187897f4@freebsd.org> On 24/05/24 12:51 GMT, Vladimir Druzenko wrote: > 24.05.2024 06:47, Robert Nagy пишет: > > The branch main has been updated by rnagy: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=b4d0a174c529e8061d838aafba1721cc317af01f > > > > commit b4d0a174c529e8061d838aafba1721cc317af01f > > Author: Robert Nagy > > AuthorDate: 2024-05-23 20:21:23 +0000 > > Commit: Robert Nagy > > CommitDate: 2024-05-24 03:47:31 +0000 > > > > www/ungoogled-chromium: update to 125.0.6422.76 and implement selectable audio backend support > > with these changes, chromium now automatically selects which > > audio backend to use in the following order: > > pulse (if running) -> sndio -> alsa -> fake > > an additional command line option has been also implemented so > > that the user can force which backend to use: > > --audio-backend={auto,sndio,pulse,alsa} > > Security: https://vuxml.freebsd.org/freebsd/8247af0d-183b-11ef-9f97-a8a1599412c6.html > > --- > > > > @@ -19,7 +19,8 @@ ONLY_FOR_ARCHS= aarch64 amd64 i386 > > PATCH_DEPENDS= gpatch:devel/patch \ > > ${PYTHON_VERSION}:lang/python${PYTHON_SUFFIX} > > -BUILD_DEPENDS= bash:shells/bash \ > > +BUILD_DEPENDS= ${LOCALBASE}/include/pulse/pulseaudio.h:audio/pulseaudio \ > > + bash:shells/bash \ > > ${PYTHON_PKGNAMEPREFIX}Jinja2>0:devel/py-Jinja2@${PY_FLAVOR} \ > > ${PYTHON_PKGNAMEPREFIX}ply>0:devel/py-ply@${PY_FLAVOR} \ > > gperf:devel/gperf \ > > @@ -38,8 +39,10 @@ BUILD_DEPENDS= bash:shells/bash \ > > LIB_DEPENDS= libatk-bridge-2.0.so:accessibility/at-spi2-core \ > > libatspi.so:accessibility/at-spi2-core \ > > libspeechd.so:accessibility/speech-dispatcher \ > > + libasound.so:audio/alsa-lib \ > > libFLAC.so:audio/flac \ > > libopus.so:audio/opus \ > > + libsndio.so:audio/sndio \ > > libspeex.so:audio/speex \ > > libdbus-1.so:devel/dbus \ > > libdbus-glib-1.so:devel/dbus-glib \ > > @@ -154,10 +162,8 @@ SUB_FILES= ungoogled-chromium.desktop ungoogled-chromium > > SUB_LIST+= COMMENT="${COMMENT}" > > OPTIONS_DEFINE= CODECS CUPS DEBUG DRIVER KERBEROS LTO PIPEWIRE TEST WIDEVINE > > -OPTIONS_DEFAULT= CODECS CUPS DRIVER KERBEROS PIPEWIRE SNDIO > > +OPTIONS_DEFAULT= CODECS CUPS DRIVER KERBEROS PIPEWIRE > > OPTIONS_EXCLUDE_aarch64=LTO > > -OPTIONS_GROUP= AUDIO > > -OPTIONS_GROUP_AUDIO= ALSA PULSEAUDIO SNDIO > > OPTIONS_RADIO= KERBEROS > > OPTIONS_RADIO_KERBEROS= HEIMDAL HEIMDAL_BASE MIT > > OPTIONS_SUB= yes > > @@ -167,12 +173,6 @@ HEIMDAL_BASE_DESC= Heimdal Kerberos (base) > > HEIMDAL_DESC= Heimdal Kerberos (security/heimdal) > > MIT_DESC= MIT Kerberos (security/krb5) > > -ALSA_LIB_DEPENDS= libasound.so:audio/alsa-lib > > -ALSA_RUN_DEPENDS= ${LOCALBASE}/lib/alsa-lib/libasound_module_pcm_oss.so:audio/alsa-plugins \ > > - alsa-lib>=1.1.1_1:audio/alsa-lib > > -ALSA_VARS= GN_ARGS+=use_alsa=true > > -ALSA_VARS_OFF= GN_ARGS+=use_alsa=false > > - > > CODECS_VARS= GN_ARGS+=proprietary_codecs=true \ > > FFMPEG_BRAND="Chrome" > > CODECS_VARS_OFF= GN_ARGS+=proprietary_codecs=false \ > > @@ -216,18 +216,6 @@ PIPEWIRE_VARS= GN_ARGS+=rtc_use_pipewire=true \ > > PIPEWIRE_VARS_OFF= GN_ARGS+=rtc_use_pipewire=false \ > > GN_ARGS+=rtc_link_pipewire=false > > -PULSEAUDIO_LIB_DEPENDS= libpulse.so:audio/pulseaudio > > -PULSEAUDIO_VARS= GN_ARGS+=use_pulseaudio=true > > -PULSEAUDIO_VARS_OFF= GN_ARGS+=use_pulseaudio=false > > - > > -# With SNDIO=on we exclude audio_manager_linux from the build (see > > -# media/audio/BUILD.gn) and use audio_manager_openbsd which does not > > -# support falling back to ALSA or PulseAudio. > > -SNDIO_PREVENTS= ALSA PULSEAUDIO > > -SNDIO_LIB_DEPENDS= libsndio.so:audio/sndio > > -SNDIO_VARS= GN_ARGS+=use_sndio=true > > -SNDIO_VARS_OFF= GN_ARGS+=use_sndio=false > > - > > WIDEVINE_DESC= Depend on foreign-cdm to enable playback of DRM content > > WIDEVINE_RUN_DEPENDS= foreign-cdm>0:www/foreign-cdm > > Please remove mandatory dependency (BUILD and LIB) from pulse and sndio and > return build options. > You can do with OPTIONS_DEFAULT what you want, but don't force install all > these dependencies even for build. I am sorry but I don't concur. Knobs are bad, there is literally no reason for someone not to install sndio (which is the most supported by chrome) by default. Pulseaudio is only a build dependency which is completely fine. I am trying to remove even more build options. They make absolutely no sense.