From owner-svn-ports-all@FreeBSD.ORG Fri Jan 17 12:54:29 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3D68A9A2; Fri, 17 Jan 2014 12:54:29 +0000 (UTC) Received: from mail-wi0-x22a.google.com (mail-wi0-x22a.google.com [IPv6:2a00:1450:400c:c05::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3379D1FB1; Fri, 17 Jan 2014 12:54:28 +0000 (UTC) Received: by mail-wi0-f170.google.com with SMTP id ex4so1991175wid.5 for ; Fri, 17 Jan 2014 04:54:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=zGk16eE+6TlioejPqN8vTS7lS2MAgcue9uTJC68Rsqs=; b=fXFbttEBWWmG+1dy+44eYFq+65Dx7+Of+zHAoihSHWu0fPFa/izjmQAr7rHTPEwJ0F oiv94pWzScRJPpnkefOyzUBJNRqPrd1nZ7Py5SZb5oxYPqsbsj07sxNx9+4u+pHIsfki v+Ksj6hSLNdSXmwwFgJ4e4Bhy8A00Fmb0Lsyg1C3X9AqMeq5egJGhtZaV+uhU48+H2n0 rMNrW16lZm4J85mCKFj9KZtS/0rABIdr5b3Uck6+ZoucobFi4f8pE04TXFnOPmAaI/0s XN+QCXjcOMFS+tdx/CY747VrfRnz0WxF4tP9KdZs0hYZ6N5TkwI+t3Oad9IHbezDWbIg Nwog== X-Received: by 10.180.106.200 with SMTP id gw8mr2269408wib.50.1389963266533; Fri, 17 Jan 2014 04:54:26 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id mv9sm3094645wic.1.2014.01.17.04.54.25 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 17 Jan 2014 04:54:25 -0800 (PST) Sender: Baptiste Daroussin Date: Fri, 17 Jan 2014 13:54:23 +0100 From: Baptiste Daroussin To: Pietro Cerutti Subject: Re: svn commit: r340026 - head/net-im/libpurple Message-ID: <20140117125423.GE79245@ithaqua.etoilebsd.net> References: <201401171033.s0HAX99I020937@svn.freebsd.org> <884B7C619AAEEC285129466D@atuin.in.mat.cc> <20140117124521.GF4006@gahrfit.gahr.ch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WBsA/oQW3eTA3LlM" Content-Disposition: inline In-Reply-To: <20140117124521.GF4006@gahrfit.gahr.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Mathieu Arnold , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jan 2014 12:54:29 -0000 --WBsA/oQW3eTA3LlM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 17, 2014 at 01:45:21PM +0100, Pietro Cerutti wrote: > On 2014-Jan-17, 11:47, Mathieu Arnold wrote: > > +--On 17 janvier 2014 10:33:09 +0000 Pietro Cerutti > > wrote: > > | .if ${PORT_OPTIONS:MTCLTK} > > | -USE_TK=3D yes > > | -CFLAGS+=3D -I${LOCALBASE}/include/tk${TK_VER} > > | -I${LOCALBASE}/include/tcl${TCL_VER} -CONFIGURE_ARGS+=3D > > | --with-tclconfig=3D${LOCALBASE}/lib/tcl${TCL_VER} \ - > > | --with-tkconfig=3D${LOCALBASE}/lib/tk${TK_VER} > > | +USES+=3D tk > > | +CFLAGS+=3D -I${TK_INCLUDEDIR} -I${TCL_INCLUDEDIR} > > | +CONFIGURE_ARGS+=3D --with-tclconfig=3D${TCL_LIBDIR} \ > > | + --with-tkconfig=3D${TK_LIBDIR} > >=20 > > Which is way better written as : > >=20 > > TCLTK_USES=3D tk > > TCLTK_CFLAGS=3D -I${TK_INCLUDEDIR} -I${TCL_INCLUDEDIR} > > TCLTK_CONFIGURE_ON=3D --with-tclconfig=3D${TCL_LIBDIR} \ > > --with-tkconfig=3D${TK_LIBDIR} >=20 > Nice framework. But given that I have to enclose stuff in > .if ${PORT_OPTIONS:MTCLTK}=20 > anyway because of PLIST_SUB and CONFIGURE_ARGS, what's the benefit? >=20 No you don't CONFIGURE_ARGS is TCLTK_CONFIGURE_* PLIST_SUB can be replaced by OPTIONS_SUB (which will create all the need @comment regards, Bapt --WBsA/oQW3eTA3LlM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLZJ/8ACgkQ8kTtMUmk6EwrsgCguxxkevwPW5NDG+mSSRFzIbn7 uFsAn2ztbafs+uPZuJkU4oeZKSTbGARM =y1pI -----END PGP SIGNATURE----- --WBsA/oQW3eTA3LlM--