From owner-svn-src-all@FreeBSD.ORG Mon Mar 29 18:18:41 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ADAED106564A; Mon, 29 Mar 2010 18:18:41 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 6C3AC8FC19; Mon, 29 Mar 2010 18:18:41 +0000 (UTC) Received: by pwj4 with SMTP id 4so8693725pwj.13 for ; Mon, 29 Mar 2010 11:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mail-followup-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=mrGIBlIhzNSyBlzuLGQ7xUK0IGBo3iJqdxp0z+ckXsY=; b=na9ezlPjLGdYyN9414M0ShhyrAgH3oEmc4+In2nelZLdNrqt/x4oIby1XpROfymMRb e3eh83A2JWzIB1643CTsD+UcW+z/PBnTzL6OF8PmLRLtBOvGgqzBHGrHXonDBkxLfaBu azvRYrAYjmE96Fiqdqj5W2BWftHiD7zkv/olM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; b=PhxmJuXb+HP1F/7iMjygl1cWeLPTsMhDK+FjEslnKObQoo9tT/Tj1RWQNDISFcnULR xs1sdXbC+7zM6x2otMKsmler7tYPN9lJw0pzG39kE7NeaB1Bd2kz9Hc+lmHixwUPQg/N jT1oscq8sUoX8p9ro2DwhYEa0U/dWf2Ov6k3I= Received: by 10.141.105.10 with SMTP id h10mr1298748rvm.45.1269886720462; Mon, 29 Mar 2010 11:18:40 -0700 (PDT) Received: from gypsy (c-67-161-10-127.hsd1.ca.comcast.net [67.161.10.127]) by mx.google.com with ESMTPS id r27sm1474878rvq.17.2010.03.29.11.18.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 29 Mar 2010 11:18:39 -0700 (PDT) Date: Mon, 29 Mar 2010 11:18:31 -0700 From: Navdeep Parhar To: Warner Losh Message-ID: <20100329181831.GA14698@gypsy> Mail-Followup-To: Warner Losh , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201003291731.o2THVtlV023212@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201003291731.o2THVtlV023212@svn.freebsd.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r205845 - head/sys/modules X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2010 18:18:41 -0000 This commit has unplugged cxgb from the build, even for the (!arm && !mips) case. Please fix. Regards, Navdeep On Mon, Mar 29, 2010 at 05:31:55PM +0000, Warner Losh wrote: > Author: imp > Date: Mon Mar 29 17:31:55 2010 > New Revision: 205845 > URL: http://svn.freebsd.org/changeset/base/205845 > > Log: > Make all the modules build on arm (modulo ipfilter, which I'm looking > into): > > o Don't build vpo and syscons on mips or arm either > o Add a section for mips and arm breakages, and document why. > This is easier than opting in on all the other architectures: > # no BUS_SPACE_UNSPECIFIED: bce, bwi, bwn, mfi, mpt, siba_bwn > # No barrier instruction support (specific to this driver): sym > # no uart_cpu_$MACHINE_ARCH: uart > > (mips has, by inspection, the same issues as arm, so ditto for it) > > MFC after: 7 days > > Modified: > head/sys/modules/Makefile > > Modified: head/sys/modules/Makefile > ============================================================================== > --- head/sys/modules/Makefile Mon Mar 29 17:26:24 2010 (r205844) > +++ head/sys/modules/Makefile Mon Mar 29 17:31:55 2010 (r205845) > @@ -34,15 +34,15 @@ SUBDIR= ${_3dfx} \ > ata \ > ath \ > ${_auxio} \ > - bce \ > + ${_bce} \ > bfe \ > bge \ > ${_bios} \ > ${_bktr} \ > ${_bm} \ > bridgestp \ > - bwi \ > - bwn \ > + ${_bwi} \ > + ${_bwn} \ > cam \ > ${_canbepm} \ > ${_canbus} \ > @@ -66,7 +66,7 @@ SUBDIR= ${_3dfx} \ > ${_cryptodev} \ > ${_cs} \ > ${_ctau} \ > - cxgb \ > + ${_cxgb} \ > ${_cyclic} \ > dc \ > dcons \ > @@ -175,13 +175,13 @@ SUBDIR= ${_3dfx} \ > mcd \ > md \ > mem \ > - mfi \ > + ${_mfi} \ > mii \ > mlx \ > ${_mly} \ > mmc \ > mmcsd \ > - mpt \ > + ${_mpt} \ > mqueue \ > msdosfs \ > msdosfs_iconv \ > @@ -251,7 +251,7 @@ SUBDIR= ${_3dfx} \ > sdhci \ > sem \ > sf \ > - siba_bwn \ > + ${_siba_bwn} \ > siis \ > sis \ > sk \ > @@ -268,7 +268,7 @@ SUBDIR= ${_3dfx} \ > stge \ > ${_streams} \ > ${_svr4} \ > - sym \ > + ${_sym} \ > ${_syscons} \ > sysvipc \ > ti \ > @@ -279,7 +279,7 @@ SUBDIR= ${_3dfx} \ > twe \ > tx \ > txp \ > - uart \ > + ${_uart} \ > ubsec \ > udf \ > udf_iconv \ > @@ -312,11 +312,26 @@ SUBDIR= ${_3dfx} \ > ${_zfs} \ > zlib \ > > -.if ${MACHINE_ARCH} != "powerpc" > +.if ${MACHINE_ARCH} != "powerpc" && ${MACHINE_ARCH} != "arm" && \ > + ${MACHINE_ARCH} != "mips" > _syscons= syscons > _vpo= vpo > .endif > > +.if ${MACHINE_ARCH} != "arm" && ${MACHINE_ARCH} != "mips" > +# no BUS_SPACE_UNSPECIFIED > +_bce= bce > +_bwi= bwi > +_bwn= bwn > +_mfi= mfi > +_mpt= mpt > +_siba_bwn= siba_bwn > +# No barrier instruction support (specific to this driver) > +_sym= sym > +# no uart_cpu_$MACHINE_ARCH > +_uart= uart > +.endif > + > .if ${MK_CRYPT} != "no" || defined(ALL_MODULES) > .if exists(${.CURDIR}/../opencrypto) > _crypto= crypto > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"