From nobody Mon Apr 27 15:58:02 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g47WZ3WZsz6bGBx for ; Mon, 27 Apr 2026 15:58:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g47WZ0zLCz3cHd for ; Mon, 27 Apr 2026 15:58:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777305482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3Umc3YS3ZrHahidc5kk8XEV2/ILe/qccPBU+drdNrGc=; b=IuGTABY0+ulzejYPLktu0E5wpHNST2U4l1f+eHUpCSUUr+9W/WLSMNS10bPZ1nVEso7kah 5imtEmEm9r4NtzqUPP49ZBjAOGvg1/x383qXOUOGdWsG2D449dop7YBT3Jm9zFLvY3SFcQ gIMjD0pJRCuK9ywPDqoz9VXWFlA9cEox0fNbBG1RCsE/U1rHRSwDeCvNoY8WY8Wky/14/4 1YxDMu28pR4h11Vdu23g4FtXMGQ/4Ma2/xG5glOpGkTFTjU5AhamY+JfiIlxrWZXEjx2qu PmasEfY4k7F+D8lZoTRUpaMSvO0IqF7GXKlQkxfBrKuyUMgyw+3aKT58CK82JA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777305482; a=rsa-sha256; cv=none; b=AhJOXgSPevCTVE/3hDE5uz4iUeuQFKLgfI1u3I3IyO9JhVl41lFctfYrc7wAK9qs+YhM2D 0C7HOCerFNih72JK2I4veq9v8EAjSxeDWjli8Wz9EjNSYtL+3obOmK2BR/bMjMdYuSPtXf dsX9R0TqXKfX9LkbcDN2htNZa4eUejTm2kbHdpCDXrftrY1NcD8oBvGdRHAsABxxp0lTlN A/m0XYgzu+LHOupY0SSlAlpSxDEC4+9sjkzXFj2t1vLSeqRX3FO4joHi8K/swjd8L/iVWU tsJn0jXiHsiCX0/4qHhiZzwtEQjOanAmir2mT+acgH8mP3bWkIRPzX/BCdgkNQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777305482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3Umc3YS3ZrHahidc5kk8XEV2/ILe/qccPBU+drdNrGc=; b=eS2E+Gfgt69mXCC7SheZHb11jZbzIPye+3K0gDfOFEBofz7uR49lUJNFzKkgwlJpUUZ3oA Bxmq5ZcByJrM7ksREMQaA/MyyEIheJpSPphrGtRK3SpZ0MaVSsV/sqnK6bs8x454KRNHfE ZWD4yWrWFYCWxAh1O8/XyvNewI7h0Sq6VoSSxoo8s+/YLZoYFI69SEKVz/8QteByNkjRW4 aPKqD04Qs7mgcHgQ+eadWr4LsT9+y6t9X/nVv7ORTLmE8f303dCVfx1qwiWr3Xz/UDS/0P 2VrQOIg+7hyqPgsDRfZy8Z9/9g+q6pi3Cx51qVSq1BgrKILX8p7fTIxjkj+j0w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g47WZ0WCfz1Cm5 for ; Mon, 27 Apr 2026 15:58:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 43091 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 27 Apr 2026 15:58:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: f65a4854bf82 - main - qcom_tlmm: add i2c pull up strength config option List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f65a4854bf82f60002e268928614e379da852005 Auto-Submitted: auto-generated Date: Mon, 27 Apr 2026 15:58:02 +0000 Message-Id: <69ef878a.43091.77818756@gitrepo.freebsd.org> The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=f65a4854bf82f60002e268928614e379da852005 commit f65a4854bf82f60002e268928614e379da852005 Author: Adrian Chadd AuthorDate: 2026-04-07 10:09:44 +0000 Commit: Adrian Chadd CommitDate: 2026-04-27 15:57:54 +0000 qcom_tlmm: add i2c pull up strength config option The X1E and others have a separate configuration bit to increase the pull-up drive strength for i2c busses. Add the plumbing; it doesn't do anything just yet. Differential Revision: https://reviews.freebsd.org/D56351 --- sys/dev/qcom_tlmm/qcom_tlmm_ipq4018_hw.c | 1 + sys/dev/qcom_tlmm/qcom_tlmm_pin.c | 5 +++++ sys/dev/qcom_tlmm/qcom_tlmm_var.h | 1 + 3 files changed, 7 insertions(+) diff --git a/sys/dev/qcom_tlmm/qcom_tlmm_ipq4018_hw.c b/sys/dev/qcom_tlmm/qcom_tlmm_ipq4018_hw.c index 12aa1b7f8305..14d1055f195a 100644 --- a/sys/dev/qcom_tlmm/qcom_tlmm_ipq4018_hw.c +++ b/sys/dev/qcom_tlmm/qcom_tlmm_ipq4018_hw.c @@ -314,6 +314,7 @@ qcom_tlmm_ipq4018_hw_pin_set_pupd_config( reg |= QCOM_TLMM_IPQ4018_REG_PIN_CONTROL_PUPD_PULLDOWN << QCOM_TLMM_IPQ4018_REG_PIN_CONTROL_PUPD_SHIFT; break; + case QCOM_TLMM_PIN_PUPD_CONFIG_STRONG_PULL_UP: case QCOM_TLMM_PIN_PUPD_CONFIG_PULL_UP: reg |= QCOM_TLMM_IPQ4018_REG_PIN_CONTROL_PUPD_PULLUP << QCOM_TLMM_IPQ4018_REG_PIN_CONTROL_PUPD_SHIFT; diff --git a/sys/dev/qcom_tlmm/qcom_tlmm_pin.c b/sys/dev/qcom_tlmm/qcom_tlmm_pin.c index 27d6f904d664..fcdcb20f6c95 100644 --- a/sys/dev/qcom_tlmm/qcom_tlmm_pin.c +++ b/sys/dev/qcom_tlmm/qcom_tlmm_pin.c @@ -101,6 +101,7 @@ qcom_tlmm_pin_configure(struct qcom_tlmm_softc *sc, pin->gp_flags |= GPIO_PIN_PULLUP; sc->sc_hw->qcom_tlmm_hw_pin_set_pupd_config(sc, pin->gp_pin, QCOM_TLMM_PIN_PUPD_CONFIG_PULL_UP); + /* XXX todo: i2c strong pull-up? */ } else if (flags & GPIO_PIN_PULLDOWN) { pin->gp_flags |= GPIO_PIN_PULLDOWN; sc->sc_hw->qcom_tlmm_hw_pin_set_pupd_config(sc, pin->gp_pin, @@ -197,6 +198,10 @@ qcom_tlmm_pin_getflags(device_t dev, uint32_t pin, uint32_t *flags) case QCOM_TLMM_PIN_PUPD_CONFIG_PULL_UP: *flags |= GPIO_PIN_PULLUP; break; + case QCOM_TLMM_PIN_PUPD_CONFIG_STRONG_PULL_UP: + /* XXX flag i2c "strong" pull-up? */ + *flags |= GPIO_PIN_PULLUP; + break; case QCOM_TLMM_PIN_PUPD_CONFIG_BUS_HOLD: *flags |= (GPIO_PIN_PULLUP | GPIO_PIN_PULLDOWN); break; diff --git a/sys/dev/qcom_tlmm/qcom_tlmm_var.h b/sys/dev/qcom_tlmm/qcom_tlmm_var.h index 4fd37f83192e..f9b9bcd9a3c8 100644 --- a/sys/dev/qcom_tlmm/qcom_tlmm_var.h +++ b/sys/dev/qcom_tlmm/qcom_tlmm_var.h @@ -95,6 +95,7 @@ typedef enum { QCOM_TLMM_PIN_PUPD_CONFIG_PULL_DOWN = 1, QCOM_TLMM_PIN_PUPD_CONFIG_PULL_UP = 2, QCOM_TLMM_PIN_PUPD_CONFIG_BUS_HOLD = 3, + QCOM_TLMM_PIN_PUPD_CONFIG_STRONG_PULL_UP = 4, /* i2c */ } qcom_tlmm_pin_pupd_config_t;