Date: Sun, 6 May 2018 17:01:17 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Koichiro Iwao <meta@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r469188 - head/ports-mgmt/pkg_replace Message-ID: <20180506150117.tfdvuj3p6wtoa4ua@ivaldir.net> In-Reply-To: <20180506102749.GA58637@FreeBSD.org> References: <201805061015.w46AF3HQ070595@repo.freebsd.org> <20180506102749.GA58637@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--iamvaf62bbhqd3gm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 06, 2018 at 10:27:49AM +0000, Alexey Dokuchaev wrote: > On Sun, May 06, 2018 at 10:15:03AM +0000, Koichiro Iwao wrote: > > New Revision: 469188 > > URL: https://svnweb.freebsd.org/changeset/ports/469188 > >=20 > > Log: > > ports-mgmt/pkg_replace: Update to 20180424 > > =20 > > - Cleanup code > > - Speed up and strictly check package's dependencies > > - While here, pet portlint by using pkg-plist instead of PLIST_FILES >=20 > Could you explain what did you achieve by moving three-line PLIST_FILES > into pkg-plist? How can "pet portlint" be a reason for a change while > we generally encourage converting <6-line pkg-plist's into PLIST_FILES? >=20 > ./danfe >=20 > > - > > -PLIST_FILES=3D sbin/pkg_replace \ > > - man/man1/pkg_replace.1.gz \ > > - "@sample %%ETCDIR%%/pkg_replace.conf.sample" >=20 > Correct PLIST_FILES should read: >=20 > PLIST_FILES=3D sbin/pkg_replace \ > man/man1/pkg_replace.1.gz \ > @sample\ etc/pkg_replace/pkg_replace.conf.sample why ? Bapt --iamvaf62bbhqd3gm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlrvGL0ACgkQY4mL3PG3 Plq25g/+JbzJEgV2Yhlw4e6HFXe1xwsRHBGBF6T8ETluU1f4+hKpF/8sTlA+DlSb ppTVvIe+HPZxMpbi0tmS4dIYqzJs2wPUqPRy4lRw5DftVb0+wNeA8FaBzRao9EF/ XYR2UoKCOzshZDLaTA91WU9Im7EgTaKurhFyPm+qmFYdKSr8OzAM7teqP8Zfdm8K bEkJO8pMq+Ab+HSETPDl+rHjQXmCJQurs/3YJge5W/HQb29CbBgKxfuxvfhmOOZm s7O9U6KDIEvzSvKw7m53hfAKhmRL2Kjj9E6DCR96E+nfMPGWHLHe+wCJYeWGK3fm qqVXYHPMCoPucNfkTcb30BlvCJqcuMLJAmyTdVA7NClLXbJIhk1IGgiTQrZps07b gkceauX8w7OIv4BgnGUqwcr3HLsMQfeaMzBaDLcymXbYADGn1lU+CbZuGyqDAUXK fA4B7hmPkLfQ2d3Ijsun4NezFzxHhuQAn7FqKrdi3ufPl84bBJ7V8Pptjj5Mt+wO ftIE5cR7H9kZDiozJRORi0rbqs3iYq4SdJb6Nr8b18q4xXvGO1h31232UDmnwOA+ 5kV7Xl0wRkZxp+5fHuwvshcgVnpyyNz22a9R1F3jL9QdvKLTpL6UZbotiXZ+r2ud RbNWOt1CqMsuKKjT47qs46EwKBE55ChUH6JeD+dhF3A6TzA2M7M= =jyXn -----END PGP SIGNATURE----- --iamvaf62bbhqd3gm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180506150117.tfdvuj3p6wtoa4ua>