Date: Tue, 8 Oct 2024 10:32:57 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 57dc9c86c152 - main - devel/R-cran-data.table: Revert "devel/R-cran-data.table: Update to 1.16.0" Message-ID: <CAFDf7UJhvr0DqgSAp52NpddT7WMDFP9zSD4LmXjyLKyrUEioMg@mail.gmail.com> In-Reply-To: <202410080924.4989O2DW090082@gitrepo.freebsd.org> References: <202410080924.4989O2DW090082@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000003f88f40623f3d3dc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable We will need to ask upstream to fix OpenMP detection on FreeBSD like macports did: https://github.com/Rdatatable/data.table/issues/6409 A quick fix is: ``` --- configure.orig 2024-10-08 08:42:43 UTC +++ configure @@ -144,7 +144,17 @@ detect_openmp () { fi # uname=3DDarwin - # No support for OpenMP available + + if [ "$(uname)" =3D "FreeBSD" ]; then + + export PKG_CFLAGS=3D"${PKG_CFLAGS}" + export PKG_LIBS=3D"${PKG_LIBS}" + export R_OPENMP_ENABLED=3D1 + return + + fi # uname=3DFreeBSD + + # No support for OpenMP available export R_OPENMP_ENABLED=3D0 } ``` But I don't have enough skills to evaluate the correct FreeBSD support. Thanks Nuno Teixeira <eduardo@freebsd.org> escreveu (ter=C3=A7a, 8/10/2024 =C3=A0(= s) 10:24): > The branch main has been updated by eduardo: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D57dc9c86c152a5abc0a367d49cbf2= 65a18b738d8 > > commit 57dc9c86c152a5abc0a367d49cbf265a18b738d8 > Author: Nuno Teixeira <eduardo@FreeBSD.org> > AuthorDate: 2024-10-08 09:16:24 +0000 > Commit: Nuno Teixeira <eduardo@FreeBSD.org> > CommitDate: 2024-10-08 09:23:19 +0000 > > devel/R-cran-data.table: Revert "devel/R-cran-data.table: Update to > 1.16.0" > > OpenMP detection broken. > > See also: > https://github.com/Rdatatable/data.table/issues/6559 > > https://github.com/Rdatatable/data.table/commit/096b20f1f1b9788787a826ba3= d32177ed9836352 > > This reverts commit 5f823f135151a2a77b54ef0533c4c932e41ca771. > --- > devel/R-cran-data.table/Makefile | 4 +--- > devel/R-cran-data.table/distinfo | 6 +++--- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/devel/R-cran-data.table/Makefile > b/devel/R-cran-data.table/Makefile > index 34a8aa0ea207..100dbe683927 100644 > --- a/devel/R-cran-data.table/Makefile > +++ b/devel/R-cran-data.table/Makefile > @@ -1,5 +1,5 @@ > PORTNAME=3D data.table > -DISTVERSION=3D 1.16.0 > +DISTVERSION=3D 1.15.4 > CATEGORIES=3D devel > DISTNAME=3D ${PORTNAME}_${DISTVERSION} > > @@ -12,8 +12,6 @@ LICENSE_FILE=3D ${WRKSRC}/LICENSE > > USES=3D cran:auto-plist,compiles pkgconfig > > -TESTING_UNSAFE=3D > https://github.com/Rdatatable/data.table/issues/6559 > - > NO_ARCH_IGNORE=3D data_table.so > > OPTIONS_DEFINE=3D OPENMP > diff --git a/devel/R-cran-data.table/distinfo > b/devel/R-cran-data.table/distinfo > index dfc347728df6..497612d9aa61 100644 > --- a/devel/R-cran-data.table/distinfo > +++ b/devel/R-cran-data.table/distinfo > @@ -1,3 +1,3 @@ > -TIMESTAMP =3D 1728300398 > -SHA256 (data.table_1.16.0.tar.gz) =3D > 58f8aec50099de80d84faa50295c17295d465f669be79b46c3c7ca18c56ef9cd > -SIZE (data.table_1.16.0.tar.gz) =3D 5302544 > +TIMESTAMP =3D 1711960872 > +SHA256 (data.table_1.15.4.tar.gz) =3D > ab8065ff946d59ecaaf5eaf91a975495c07c30caad97a71205c72e41a740cb53 > +SIZE (data.table_1.15.4.tar.gz) =3D 5387593 > --=20 Nuno Teixeira FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org --0000000000003f88f40623f3d3dc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>We will need to ask upstream to fix OpenMP detection = on FreeBSD like macports did:</div><div><br></div><div><a href=3D"https://g= ithub.com/Rdatatable/data.table/issues/6409">https://github.com/Rdatatable/= data.table/issues/6409</a></div><div><br></div><div>A quick fix is:<br><br>= ```</div><div>--- configure.orig =C2=A0 =C2=A0 =C2=A02024-10-08 08:42:43 UT= C<br>+++ configure<br>@@ -144,7 +144,17 @@ detect_openmp () {<br><br>=C2=A0= =C2=A0fi # uname=3DDarwin<br><br>- =C2=A0# No support for OpenMP available= <br>+<br>+ =C2=A0if [ "$(uname)" =3D "FreeBSD" ]; then<= br>+<br>+ =C2=A0 =C2=A0export PKG_CFLAGS=3D"${PKG_CFLAGS}"<br>+ = =C2=A0 =C2=A0export PKG_LIBS=3D"${PKG_LIBS}"<br>+ =C2=A0 =C2=A0ex= port R_OPENMP_ENABLED=3D1<br>+ =C2=A0 =C2=A0return<br>+<br>+ =C2=A0fi # una= me=3DFreeBSD<br>+<br>+ # No support for OpenMP available<br>=C2=A0 =C2=A0ex= port R_OPENMP_ENABLED=3D0<br>=C2=A0}</div><div>```<br><br></div><div>But I = don't have enough skills to evaluate the correct FreeBSD support.<br><b= r></div><div>Thanks<br></div></div><br><div class=3D"gmail_quote"><div dir= =3D"ltr" class=3D"gmail_attr">Nuno Teixeira <<a href=3D"mailto:eduardo@f= reebsd.org">eduardo@freebsd.org</a>> escreveu (ter=C3=A7a, 8/10/2024 =C3= =A0(s) 10:24):<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0= px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">T= he branch main has been updated by eduardo:<br> <br> URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D57dc9c86c152a5a= bc0a367d49cbf265a18b738d8" rel=3D"noreferrer" target=3D"_blank">https://cgi= t.FreeBSD.org/ports/commit/?id=3D57dc9c86c152a5abc0a367d49cbf265a18b738d8</= a><br> <br> commit 57dc9c86c152a5abc0a367d49cbf265a18b738d8<br> Author:=C2=A0 =C2=A0 =C2=A0Nuno Teixeira <eduardo@FreeBSD.org><br> AuthorDate: 2024-10-08 09:16:24 +0000<br> Commit:=C2=A0 =C2=A0 =C2=A0Nuno Teixeira <eduardo@FreeBSD.org><br> CommitDate: 2024-10-08 09:23:19 +0000<br> <br> =C2=A0 =C2=A0 devel/R-cran-data.table: Revert "devel/R-cran-data.table= : Update to 1.16.0"<br> <br> =C2=A0 =C2=A0 OpenMP detection broken.<br> <br> =C2=A0 =C2=A0 See also:<br> =C2=A0 =C2=A0 <a href=3D"https://github.com/Rdatatable/data.table/issues/65= 59" rel=3D"noreferrer" target=3D"_blank">https://github.com/Rdatatable/data= .table/issues/6559</a><br> =C2=A0 =C2=A0 <a href=3D"https://github.com/Rdatatable/data.table/commit/09= 6b20f1f1b9788787a826ba3d32177ed9836352" rel=3D"noreferrer" target=3D"_blank= ">https://github.com/Rdatatable/data.table/commit/096b20f1f1b9788787a826ba3= d32177ed9836352</a><br> <br> =C2=A0 =C2=A0 This reverts commit 5f823f135151a2a77b54ef0533c4c932e41ca771.= <br> ---<br> =C2=A0devel/R-cran-data.table/Makefile | 4 +---<br> =C2=A0devel/R-cran-data.table/distinfo | 6 +++---<br> =C2=A02 files changed, 4 insertions(+), 6 deletions(-)<br> <br> diff --git a/devel/R-cran-data.table/Makefile b/devel/R-cran-data.table/Mak= efile<br> index 34a8aa0ea207..100dbe683927 100644<br> --- a/devel/R-cran-data.table/Makefile<br> +++ b/devel/R-cran-data.table/Makefile<br> @@ -1,5 +1,5 @@<br> =C2=A0PORTNAME=3D=C2=A0 =C2=A0 =C2=A0 data.table<br> -DISTVERSION=3D=C2=A0 =C2=A01.16.0<br> +DISTVERSION=3D=C2=A0 =C2=A01.15.4<br> =C2=A0CATEGORIES=3D=C2=A0 =C2=A0 devel<br> =C2=A0DISTNAME=3D=C2=A0 =C2=A0 =C2=A0 ${PORTNAME}_${DISTVERSION}<br> <br> @@ -12,8 +12,6 @@ LICENSE_FILE=3D ${WRKSRC}/LICENSE<br> <br> =C2=A0USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cran:auto-plist,compiles pk= gconfig<br> <br> -TESTING_UNSAFE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 <a href=3D"https://github.com= /Rdatatable/data.table/issues/6559" rel=3D"noreferrer" target=3D"_blank">ht= tps://github.com/Rdatatable/data.table/issues/6559</a><br> -<br> =C2=A0NO_ARCH_IGNORE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 data_table.so<br> <br> =C2=A0OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 OPENMP<br> diff --git a/devel/R-cran-data.table/distinfo b/devel/R-cran-data.table/dis= tinfo<br> index dfc347728df6..497612d9aa61 100644<br> --- a/devel/R-cran-data.table/distinfo<br> +++ b/devel/R-cran-data.table/distinfo<br> @@ -1,3 +1,3 @@<br> -TIMESTAMP =3D 1728300398<br> -SHA256 (data.table_1.16.0.tar.gz) =3D 58f8aec50099de80d84faa50295c17295d46= 5f669be79b46c3c7ca18c56ef9cd<br> -SIZE (data.table_1.16.0.tar.gz) =3D 5302544<br> +TIMESTAMP =3D 1711960872<br> +SHA256 (data.table_1.15.4.tar.gz) =3D ab8065ff946d59ecaaf5eaf91a975495c07c= 30caad97a71205c72e41a740cb53<br> +SIZE (data.table_1.15.4.tar.gz) =3D 5387593<br> </blockquote></div><br clear=3D"all"><br><span class=3D"gmail_signature_pre= fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"l= tr"><div><font color=3D"#888888">Nuno Teixeira</font></div><div><div><font = color=3D"#888888"> FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 <a h= ref=3D"https://FreeBSD.org" rel=3D"noreferrer" target=3D"_blank">https://Fr= eeBSD.org</a><br></font></div></div></div></div> --0000000000003f88f40623f3d3dc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UJhvr0DqgSAp52NpddT7WMDFP9zSD4LmXjyLKyrUEioMg>