From owner-freebsd-hackers@FreeBSD.ORG Sun Nov 23 14:15:50 2003 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B20C716A4CE for ; Sun, 23 Nov 2003 14:15:50 -0800 (PST) Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id EA47943FAF for ; Sun, 23 Nov 2003 14:15:49 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: from apollo.backplane.com (localhost [127.0.0.1]) hANMFniF066838 for ; Sun, 23 Nov 2003 14:15:49 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.12.9p2/8.12.9/Submit) id hANMFnx8066837; Sun, 23 Nov 2003 14:15:49 -0800 (PST) (envelope-from dillon) Date: Sun, 23 Nov 2003 14:15:49 -0800 (PST) From: Matthew Dillon Message-Id: <200311232215.hANMFnx8066837@apollo.backplane.com> To: freebsd-hackers@freebsd.org Subject: Minor bug in kern_sysctl.c on stable X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Nov 2003 22:15:50 -0000 In kern_sysctl.c I see you guys fixed the OID_AUTO collision with static OID's, but you still have to make the minimum OID_AUTO number 256, not 100 (around line 119 of kern_sysctl.c), or you may conflict with static OID's assigned from loadable modules. I don't know of any situations that can cause this, but the more complete fix still needs to be made to -stable. -current already sets the minimum to 256 (0x100) -Matt Matthew Dillon