From owner-svn-ports-head@freebsd.org  Mon Jul  2 03:25:06 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 94F5A1027D90;
 Mon,  2 Jul 2018 03:25:06 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4ECF58DE37;
 Mon,  2 Jul 2018 03:25:06 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 47B05B5E6; Mon,  2 Jul 2018 03:25:06 +0000 (UTC)
Date: Mon, 2 Jul 2018 03:25:06 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mark Linimon <linimon@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r473698 - head/emulators/simh
Message-ID: <20180702032506.GA73255@FreeBSD.org>
References: <201807020308.w6238vSs002453@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201807020308.w6238vSs002453@repo.freebsd.org>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Jul 2018 03:25:06 -0000

On Mon, Jul 02, 2018 at 03:08:57AM +0000, Mark Linimon wrote:
> New Revision: 473698
> URL: https://svnweb.freebsd.org/changeset/ports/473698
> 
> Log:
>   Attempt to see if the build can be fixed on non-clang-based archs.
>   
> [...]
> +.include <bsd.port.pre.mk>
> +
> +.if ${ARCH} == aarch64 || ${ARCH} == amd64 || ${ARCH} == armv6 || ${ARCH} == armv7 || ${ARCH} == i386
> +CFLAGS+=	-Wno-logical-op-parentheses -Wno-bitwise-op-parentheses -Wno-shift-negative-value
> +.endif

Hmm, perhaps a better approach would've been to USES+=compiler:env and
set CFLAGS based on COMPILER_TYPE (or is it CHOSEN_COMPILER_TYPE?) rather
than hardcode all those arch names.

./danfe