From nobody Sun Dec 3 10:21:07 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SjjWD5tBWz52f1W; Sun, 3 Dec 2023 10:21:12 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SjjWD2FgNz3ZwJ; Sun, 3 Dec 2023 10:21:12 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701598872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l4sp4YkeM52KvghdC1KJFBwCktpLZ+nFtsoJJowBxD4=; b=sYxwAub9PLvqs2ZNABTxq6b5cgNCQW9Sc/GJLNAkXg4f1sNXQBe7GwFUbJcsPqzVHX3yIa xLRGZz++J14XIhHmgRXQEAlgiya5DMMWjEV5mOfPxeF6pLiTPcZGcxwLeag7kC6quXdSf6 Spu4JoEpGfkNgE7fhKi+TxQBJ4v0Dz6u4CeOr3vaO4rLdqfL/9phVJVJHeWVkRL5BkfGBo yNz4mS7O79aXMK/y8aL0NsMlH7RJ9MkhFU69uUaaNZlK0yegEWipU1Lz1ljxru121OEV+Z piNGyrMEDu9/tXtzH2R96v1RMa6Rv3siE6+wJTQHoOqW7TKq1LsVb9VMnDfd7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701598872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l4sp4YkeM52KvghdC1KJFBwCktpLZ+nFtsoJJowBxD4=; b=qYU3FZBChxVUURNd9mzTUm/H5/4zYFXQdKUYc48YYdT4Wy5YGfQqWt5CGmCKTUUDf2pVNO NLUWPWwP6A4PDHSoUrmTAVezjmVHFUNX2f4WEUBpobsj8ZEhSvH8reLj9bNcFqNOJr75KW Eas9errg9AAA6oJoR/lRQPXGmDI7JGtB0msBeupCPi+sGxYLtvoC69z2LT/9xNJqS386A0 oa0gGyRWWS5qNV/gAKEI7WQkmvWDX5ADBRkt5vHnmm3KK6ENlrrW7AgQ3PhU3qI2JOOrQe p+VSW9Ted1Ut5etFYV5qQ7tC+8tNkAodDeeKxUBhiuYXe7pjMrHQuCQyEAtXVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701598872; a=rsa-sha256; cv=none; b=ji0t1VCxWoQXuKmIrAHJPns9TWTU6FsXT+eyVJUy28WtnaiwjKveWg9foIbRKCq7m99cOP 6RhAo2TQ0zt4z1sWif/IXIuji3mBlU1VERhjBiLvVHowU2nCnKnid7s+e6MO5MIJR0Hx2l UFx9Axiax2o0VuSQsZoMsvYfie7Xzava5TK+aaWYWePqLIFPP5/loFM1mmCQKHmUBm3U9A g7ys+u+AMqeXeEdZ5Bu3Fz9yQFS/6SDWK3JtNWlEOacFtCdC08LA+XiE578uoRs5jS3go9 iHz/QVfva+V2XNhkxdFAm3YB4ftwD3RLA3KOqLYriPgrPc1+zQ4+FpJK5FhgNw== Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SjjWD0Vj6z9Vv; Sun, 3 Dec 2023 10:21:12 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:2e02:3bff:78b8:a2fe]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 0D1F0942D80; Sun, 3 Dec 2023 10:21:09 +0000 (UTC) Date: Sun, 3 Dec 2023 11:21:07 +0100 From: Mathieu Arnold To: Jochen Neumeister Cc: Koichiro Iwao , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org, "portmgr@FreeBSD.org" Subject: Re: git: 8848573087ff - 2023Q4 - www/nginx: fix build with a third-party passenger module Message-ID: References: <202312030958.3B39wDQA036372@gitrepo.freebsd.org> <8ce4f3ab-54d2-422c-96d3-9b2094fa6099@FreeBSD.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jam5usklcmkaoaww" Content-Disposition: inline In-Reply-To: <8ce4f3ab-54d2-422c-96d3-9b2094fa6099@FreeBSD.org> --jam5usklcmkaoaww Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 03, 2023 at 11:01:26AM +0100, Jochen Neumeister wrote: > Is it normal that you just do something like that here without consulting > anyone? What do we have rules for here? Well, who would meta@ need to consult about this? It is a simple fix, any committer can commit those, and also any committer can merge it into the current quarterly. Here is the rule, taken from https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-main= tainer that explicitly says that: Maintainers have the primary responsibility for their ports, but not exclusive ownership. Ports exist for the benefit of the community and, in reality, belong to the community. What this means is that people other than the maintainer can make changes to a port. >=20 > Am 03.12.23 um 10:58 schrieb Koichiro Iwao: > > The branch 2023Q4 has been updated by meta: > >=20 > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D8848573087ff210c5383ad= cd899b055c50467fb4 > >=20 > > commit 8848573087ff210c5383adcd899b055c50467fb4 > > Author: Jochen Neumeister > > AuthorDate: 2023-12-03 07:51:41 +0000 > > Commit: Koichiro Iwao > > CommitDate: 2023-12-03 09:57:04 +0000 > >=20 > > www/nginx: fix build with a third-party passenger module > > PR: 275161 > > Sponsored by: Netzkommune GmbH > > This commit is required to complete PR 275161. The fix for > > www/nginx-devel is not necessary at the moment. > > (cherry picked from commit b31426d1f77c12e47a60ff4b6b663826afd4702= f) > > --- > > www/nginx/Makefile | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > >=20 > > diff --git a/www/nginx/Makefile b/www/nginx/Makefile > > index be56e8b593c4..d037ba99710a 100644 > > --- a/www/nginx/Makefile > > +++ b/www/nginx/Makefile > > @@ -1,6 +1,6 @@ > > PORTNAME=3D nginx > > PORTVERSION=3D 1.24.0 > > -PORTREVISION?=3D 12 > > +PORTREVISION?=3D 13 > > PORTEPOCH=3D 3 > > CATEGORIES=3D www > > MASTER_SITES=3D https://nginx.org/download/ \ > > @@ -240,6 +240,10 @@ CONFIGURE_ENV+=3D OPTIMIZE=3D"yes" > > CFLAGS+=3D -DNDEBUG > > .endif > > +.if ${PORT_OPTIONS:MPASSENGER} > > +CONFIGURE_ENV+=3D EXTRA_PRE_CXXFLAGS=3D"-std=3Dc++14" > > +.endif > > + > > # Fix build failure on clang >=3D 12 > > .if ${PORT_OPTIONS:MHTTP_PERL} && ${OSVERSION} >=3D 1301000 > > CFLAGS+=3D -Wno-compound-token-split-by-macro >=20 --=20 Mathieu Arnold --jam5usklcmkaoaww Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmVsVpJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb54dQwAs0CGpvso7P5rDjjx9bVRe1m6+H8YCxHrVn87ndEDWOwC769lWqAlrNBY 10iWADEkDLH8h1CUpbzVRn+0auqHQbu3Fo763j9A2b3VgJw/0eAkm0sr3xSQVcCu UhHnUbYdmpybz4tTWgE2tu8Y9uCQKLLMD8WvrUG8zefsYusCjcPvzCUuPEv+MsSW VKCvam0yff6zyFvVkY2vs+IOR9Zhptwd00pg0YCR5SXbxOqFim6S6w+ZLWKlVALp FPwZ97+sSowGVAznKAAeUdm5zKeXOc4BJ8mK4celjh4GcIxwbpVk4gsaP3jXiIQf RtluZPAcrGcRWfSD2ApNdLx7ZfIodAoeU0xpVPW6kvV0ZzN3BrSaE2/74c1MDEKZ vmK53+cvXrlIbd/Put57v7kZ5ehqSMGcIQhdNgb/NbHKZMlAa3osQx6DEiUxyS1B uBsKHHA7fQvLXu/DPvMWaLCLEkrE4rxUg/XkT/KKP4kYJIqcw+ikA4EpKiHlLskR Pi+EPf7M =vjDE -----END PGP SIGNATURE----- --jam5usklcmkaoaww--