From owner-freebsd-hackers@FreeBSD.ORG Fri May 9 14:37:16 2003 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 761F137B401 for ; Fri, 9 May 2003 14:37:16 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 87B0E43F85 for ; Fri, 9 May 2003 14:37:15 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h49LbCxa014501; Fri, 9 May 2003 23:37:13 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: "Artem 'Zazoobr' Ignatiev" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sat, 10 May 2003 00:59:44 +0400." <20030510005944.A53407@memphis.mephi.ru> Date: Fri, 09 May 2003 23:37:12 +0200 Message-ID: <14500.1052516232@critter.freebsd.dk> cc: freebsd-hackers@freebsd.org Subject: Re: solaris/x86 disklabel geom class X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 May 2003 21:37:16 -0000 In message <20030510005944.A53407@memphis.mephi.ru>, "Artem 'Zazoobr' Ignatiev" writes: > >--cWoXeonUoKmBZSoM >Content-Type: text/plain; charset=us-ascii >Content-Disposition: inline > >Hello, > I wrote geom class that handles SUN solaris/x86 disklabels, and want > someone to review it... > Attached is a gzipped patch. > Sinceherely yours, Artem 'Zazoobr' Ignatjev. Thanks for the submission, but there are a number of problems that needs to be addressed with this. I would really love to receive a binary image of the relevant sectors from an sunx86 labeled disk (the one you sent me earlier did not contain it), because that would allow me determine if we can reuse code from geom_sunlabel for it. Second, your contributed code has what looks like a rather carefree attitude to copyright messages: +/* + * This file was imported by timon@memphis.mephi.ru + * Some fixes were made to compile under FreeBSD + * Original copyright below. + * Original filename was sys/dklabel.h + * Copyright (c) 2003 by Artem Ignatiev + */ +/* + * Copyright (c) 1990-1998 by Sun Microsystems, Inc. + * All rights reserved. + */ + -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.