Date: Fri, 11 Mar 2011 21:50:46 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Andriy Gapon <avg@freebsd.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r219526 - stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <20110311195046.GQ78089@deviant.kiev.zoral.com.ua> In-Reply-To: <201103111927.p2BJRVu3091029@svn.freebsd.org> References: <201103111927.p2BJRVu3091029@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--aaUKsgtkw/mqWK8Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 11, 2011 at 07:27:31PM +0000, Andriy Gapon wrote: > Author: avg > Date: Fri Mar 11 19:27:31 2011 > New Revision: 219526 > URL: http://svn.freebsd.org/changeset/base/219526 >=20 > Log: > use even larger stack size for ZFS txg_sync_thread > =20 > While the stack size was larger than the default stack size on i386, it > was smaller than the default stack size on amd64 and apparently that > wasn't enough. So, bump the size to 4 pages. Upcoming ZFSv28 code uses > 8 pages for this stack size. > =20 > This is a direct commit to stable/8. > =20 > PR: kern/154681 > Discussed with: pjd >=20 > Modified: > stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c >=20 > Modified: stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c Fri Mar= 11 19:21:42 2011 (r219525) > +++ stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c Fri Mar= 11 19:27:31 2011 (r219526) > @@ -146,7 +146,7 @@ txg_sync_start(dsl_pool_t *dp) > * 32-bit x86. This is due in part to nested pools and > * scrub_visitbp() recursion. > */ > - tx->tx_sync_thread =3D thread_create(NULL, 12<<10, txg_sync_thread, > + tx->tx_sync_thread =3D thread_create(NULL, 16<<10, txg_sync_thread, > dp, 0, &p0, TS_RUN, minclsyspri); > =20 > mutex_exit(&tx->tx_sync_lock); What about architectures where PAGE_SIZE !=3D 4096 ? We have ptoa() macro. --aaUKsgtkw/mqWK8Q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk16fRYACgkQC3+MBN1Mb4gi7QCg0sJ2PyZ/Du7929rnHMao1uVl Z1UAoKPEFlJlJDayywH0I0tkb2giKM7u =9Efe -----END PGP SIGNATURE----- --aaUKsgtkw/mqWK8Q--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110311195046.GQ78089>