From owner-freebsd-stable@FreeBSD.ORG Thu Dec 16 13:50:10 2004 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 922B316A53F for ; Thu, 16 Dec 2004 13:50:10 +0000 (GMT) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id D555D43D2D for ; Thu, 16 Dec 2004 13:50:09 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 0C81D1FF9AF; Thu, 16 Dec 2004 14:50:08 +0100 (CET) Received: by transport.cksoft.de (Postfix, from userid 66) id 073231FF9AB; Thu, 16 Dec 2004 14:50:05 +0100 (CET) Received: by mail.int.zabbadoz.net (Postfix, from userid 1060) id 42BAA154DA; Thu, 16 Dec 2004 13:45:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.int.zabbadoz.net (Postfix) with ESMTP id 3F9601539D; Thu, 16 Dec 2004 13:45:50 +0000 (UTC) Date: Thu, 16 Dec 2004 13:45:50 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net To: Heinz Knocke In-Reply-To: <006301c4e2f4$26a67fc0$df5561d9@ALFA> Message-ID: References: <003501c4e228$5f2cd780$df5561d9@ALFA> <006301c4e2f4$26a67fc0$df5561d9@ALFA> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de cc: freebsd-stable@freebsd.org Subject: Re: Marvell 88E8001 on sk0 and RELENG_5_3 - big problems X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Dec 2004 13:50:10 -0000 On Wed, 15 Dec 2004, Heinz Knocke wrote: Hi, > I got the the latest RELENG_5 and nothing's changed :( Still cannot send jumbo packets. > > But I tried this patch http://www.openbsd.org/cgi-bin/cvsweb/src/sys/dev/pci/if_sk.c.diff?r1=1.51&r2=1.52 > and IT WORKED :)) I'm almost sure that these changes wasn't in the RELENG_5 tree, there's a chance than sth was wrong with my cvsup configuration, but please check. would you mind trying this patch. It should only activate jumbo frames conditional on interface MTU like we do for xmacii. Index: sys/pci/if_sk.c =================================================================== RCS file: /local/mirror/FreeBSD/r/ncvs/src/sys/pci/if_sk.c,v retrieving revision 1.92 diff -u -p -r1.92 if_sk.c --- sys/pci/if_sk.c 17 Nov 2004 21:35:22 -0000 1.92 +++ sys/pci/if_sk.c 16 Dec 2004 10:49:48 -0000 @@ -2438,8 +2438,13 @@ sk_init_yukon(sc_if) { u_int32_t phy; u_int16_t reg; + struct sk_softc *sc; + struct ifnet *ifp; int i; + sc = sc_if->sk_softc; + ifp = &sc_if->arpcom.ac_if; + /* GMAC and GPHY Reset */ SK_IF_WRITE_4(sc_if, 0, SK_GPHY_CTRL, SK_GPHY_RESET_SET); SK_IF_WRITE_4(sc_if, 0, SK_GMAC_CTRL, SK_GMAC_RESET_SET); @@ -2490,8 +2495,10 @@ sk_init_yukon(sc_if) YU_TPR_JAM_IPG(0xb) | YU_TPR_JAM2DATA_IPG(0x1a) ); /* serial mode register */ - SK_YU_WRITE_2(sc_if, YUKON_SMR, YU_SMR_DATA_BLIND(0x1c) | - YU_SMR_MFL_VLAN | YU_SMR_IPG_DATA(0x1e)); + reg = YU_SMR_DATA_BLIND(0x1c) | YU_SMR_MFL_VLAN | YU_SMR_IPG_DATA(0x1e); + if (ifp->if_mtu > (ETHERMTU + ETHER_HDR_LEN + ETHER_CRC_LEN)) + reg |= YU_SMR_MFL_JUMBO; + SK_YU_WRITE_2(sc_if, YUKON_SMR, reg); /* Setup Yukon's address */ for (i = 0; i < 3; i++) { -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT