From owner-freebsd-current@FreeBSD.ORG Thu May 27 19:13:10 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0A7DA1065674; Thu, 27 May 2010 19:13:10 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 95CAD8FC14; Thu, 27 May 2010 19:13:09 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o4RJDCMZ054725 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 27 May 2010 22:13:12 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o4RJCxAE025146; Thu, 27 May 2010 22:12:59 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o4RJCwab025145; Thu, 27 May 2010 22:12:58 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 27 May 2010 22:12:58 +0300 From: Kostik Belousov To: Doug Barton Message-ID: <20100527191258.GQ83316@deviant.kiev.zoral.com.ua> References: <4BFD4AE6.5040105@cs.rice.edu> <20100526165141.GF83316@deviant.kiev.zoral.com.ua> <4BFEBFE3.9030606@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4CM1oNDqiDLyatGS" Content-Disposition: inline In-Reply-To: <4BFEBFE3.9030606@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_50, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: alc@freebsd.org, Garrett Cooper , FreeBSD Current , Alan Cox Subject: Re: nvidia-driver 195.22 use horribly broken on amd64 between r206173 and X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 May 2010 19:13:10 -0000 --4CM1oNDqiDLyatGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 27, 2010 at 11:54:27AM -0700, Doug Barton wrote: > On 05/26/10 09:51, Kostik Belousov wrote: > >I did a quick glance over the driver, try this: > >http://people.freebsd.org/~kib/misc/nvidia-vm_page_lock.1.patch > >I did not even compiled the patched driver. >=20 > cc -pipe -g -g -g -DNV_VERSION_STRING=3D\"195.36.15\" -D__KERNEL__ -DNVRM= =20 > -O -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I/src -I. -I@=20 > -I@/contrib/altq -finline-limit=3D8000 --param inline-unit-growth=3D100= =20 > --param large-function-growth=3D1000 -fno-common -g=20 > -mno-align-long-strings -mpreferred-stack-boundary=3D2 -mno-mmx=20 > -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fstack-protector= =20 > -std=3Diso9899:1999 -fstack-protector -Wall -Wredundant-decls=20 > -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes=20 > -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign=20 > -fformat-extensions -c nvidia_subr.c > cc1: warnings being treated as errors > nvidia_subr.c: In function 'nv_alloc_system_pages': > nvidia_subr.c:1306: warning: implicit declaration of function 'vm_page_lo= ck' > nvidia_subr.c:1306: warning: nested extern declaration of 'vm_page_lock' > nvidia_subr.c:1308: warning: implicit declaration of function=20 > 'vm_page_unlock' > nvidia_subr.c:1308: warning: nested extern declaration of 'vm_page_unlock' > *** Error code 1 I think you have stale/wrong includes used by the build. I just checked that driver indeed builds with my patch. vm_page_lock() and vm_page_unlock() are the macros defined in vm/vm_page.h that are present since first Kip commit. Look at the target of the "@" symlink in the driver directory. --4CM1oNDqiDLyatGS Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkv+xDoACgkQC3+MBN1Mb4ha2QCgr3XueFjnCt6Twhi7IXS+O6SV pZIAn3XdbQIIdiNV8BujFcwx98xraksl =ZTn0 -----END PGP SIGNATURE----- --4CM1oNDqiDLyatGS--