From owner-cvs-all Tue Sep 12 11:58:27 2000 Delivered-To: cvs-all@freebsd.org Received: from gidora.zeta.org.au (gidora.zeta.org.au [203.26.10.25]) by hub.freebsd.org (Postfix) with SMTP id BCB0737B42C for ; Tue, 12 Sep 2000 11:58:21 -0700 (PDT) Received: (qmail 8062 invoked from network); 12 Sep 2000 18:58:18 -0000 Received: from unknown (HELO bde.zeta.org.au) (203.2.228.102) by gidora.zeta.org.au with SMTP; 12 Sep 2000 18:58:18 -0000 Date: Wed, 13 Sep 2000 05:58:15 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 trap.c In-Reply-To: <200009121841.LAA30384@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 12 Sep 2000, Bruce Evans wrote: > bde 2000/09/12 11:41:56 PDT > > Modified files: > sys/i386/i386 trap.c > Log: > Quick fix for hang on booting with -d. mtx_enter() was called before > curproc was initialized. curproc == NULL was interpreted as matching > the process holding Giant... Just skip mtx_enter() and mtx_exit() in > trap() if (curproc == NULL && cold) (&& cold for safety). > > Revision Changes Path > 1.154 +5 -3 src/sys/i386/i386/trap.c Oops. This was not quite the version that I tested, so it doesn't work. It is a no-op. init386() sets curproc early, and the hang is deeper in mtx_enter(). Testing for (cold) works but is not obviously safe. Fixes tomorrow. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message