From owner-svn-src-stable@freebsd.org Tue Jan 12 09:03:40 2016 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A784CA6C5DF; Tue, 12 Jan 2016 09:03:40 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7466D1B37; Tue, 12 Jan 2016 09:03:40 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u0C93dLO012028; Tue, 12 Jan 2016 09:03:39 GMT (envelope-from hselasky@FreeBSD.org) Received: (from hselasky@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u0C93d0X012027; Tue, 12 Jan 2016 09:03:39 GMT (envelope-from hselasky@FreeBSD.org) Message-Id: <201601120903.u0C93d0X012027@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: hselasky set sender to hselasky@FreeBSD.org using -f From: Hans Petter Selasky Date: Tue, 12 Jan 2016 09:03:39 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org Subject: svn commit: r293737 - stable/9/sys/ofed/include/linux X-SVN-Group: stable-9 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2016 09:03:40 -0000 Author: hselasky Date: Tue Jan 12 09:03:39 2016 New Revision: 293737 URL: https://svnweb.freebsd.org/changeset/base/293737 Log: MFC r292989: Handle when filedescriptors are closed before initialized. An early fdclose() call can cause fget_unlocked() to fail. Modified: stable/9/sys/ofed/include/linux/file.h Directory Properties: stable/9/ (props changed) stable/9/sys/ (props changed) Modified: stable/9/sys/ofed/include/linux/file.h ============================================================================== --- stable/9/sys/ofed/include/linux/file.h Tue Jan 12 09:00:19 2016 (r293736) +++ stable/9/sys/ofed/include/linux/file.h Tue Jan 12 09:03:39 2016 (r293737) @@ -90,8 +90,12 @@ fd_install(unsigned int fd, struct linux struct file *file; file = fget_unlocked(curthread->td_proc->p_fd, fd); - filp->_file = file; - finit(file, filp->f_mode, DTYPE_DEV, filp, &linuxfileops); + if (file == NULL) { + filp->_file = NULL; + } else { + filp->_file = file; + finit(file, filp->f_mode, DTYPE_DEV, filp, &linuxfileops); + } /* drop the extra reference */ fput(filp);