From owner-freebsd-hackers@FreeBSD.ORG  Thu Oct  7 17:47:55 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0EB2210656A4
	for <hackers@freebsd.org>; Thu,  7 Oct 2010 17:47:55 +0000 (UTC)
	(envelope-from avg@freebsd.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 5C5F38FC19
	for <hackers@freebsd.org>; Thu,  7 Oct 2010 17:47:53 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id UAA18557;
	Thu, 07 Oct 2010 20:40:50 +0300 (EEST)
	(envelope-from avg@freebsd.org)
Message-ID: <4CAE0621.3070809@freebsd.org>
Date: Thu, 07 Oct 2010 20:40:49 +0300
From: Andriy Gapon <avg@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.9) Gecko/20100920 Lightning/1.0b2 Thunderbird/3.1.4
MIME-Version: 1.0
To: hackers@freebsd.org, freebsd-current@freebsd.org
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: 
Subject: panic_cpu should be volatile
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Oct 2010 17:47:55 -0000


panic_cpu variable in kern_shutdown.c should be volatile otherwise it's cached in
a register in the innermost while-loop in this code (observed on amd64 with base
gcc and -O2):
if (panic_cpu != PCPU_GET(cpuid))
        while (atomic_cmpset_int(&panic_cpu, NOCPU,
            PCPU_GET(cpuid)) == 0)
                while (panic_cpu != NOCPU)
                        ; /* nothing */

The patch is here:
http://people.freebsd.org/~avg/panic_cpu.diff

I also took a liberty to move the variable into the scope of panic() functions as
it doesn't seem to be useful outside of it.  But this is not necessary, of course.

Big thanks to mdf@ for the hint and to kib@ and kan@ for memory model expertise.

P.S.
The assembly:
        .loc 1 544 0
        movl    panic_cpu(%rip), %eax
.LVL134:
        .p2align 4,,7
.L210:
        cmpl    $255, %eax
        jne     .L210
        jmp     .L225
-- 
Andriy Gapon