From owner-freebsd-ports@FreeBSD.ORG  Thu Jan 24 16:35:36 2013
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 9E6F746F
 for <freebsd-ports@freebsd.org>; Thu, 24 Jan 2013 16:35:36 +0000 (UTC)
 (envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id 617D93DB
 for <freebsd-ports@freebsd.org>; Thu, 24 Jan 2013 16:35:35 +0000 (UTC)
Received: from ds4.des.no (smtp.des.no [194.63.250.102])
 by smtp-int.des.no (Postfix) with ESMTP id E65816F8E;
 Thu, 24 Jan 2013 16:35:33 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
 id BAAA8A461; Thu, 24 Jan 2013 17:35:33 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Michael Gmelin <freebsd@grem.de>
Subject: Re: Using bidirectional authentication in pkgng
References: <20130118035721.283135fb@bsd64.grem.de>
 <50F9B6CC.3040303@infracaninophile.co.uk>
 <20130122193035.4c51be04@bsd64.grem.de>
 <20130123004147.GG27275@ithaqua.etoilebsd.net>
 <86d2wuvrjg.fsf@ds4.des.no> <20130124121942.07436be3@bsd64.grem.de>
 <86r4lau2wh.fsf@ds4.des.no> <20130124151629.588c33c8@bsd64.grem.de>
 <86libitxit.fsf@ds4.des.no> <20130124170014.57c5fa1a@bsd64.grem.de>
Date: Thu, 24 Jan 2013 17:35:33 +0100
In-Reply-To: <20130124170014.57c5fa1a@bsd64.grem.de> (Michael Gmelin's message
 of "Thu, 24 Jan 2013 17:00:14 +0100")
Message-ID: <868v7itu7e.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-ports@freebsd.org
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jan 2013 16:35:36 -0000

Michael Gmelin <freebsd@grem.de> writes:
> Dag-Erling Sm=C3=B8rgrav <des@des.no> writes:
> > Some of the code in http.c is so deeply nested that it is almost
> > impossible to stay within 80 characters.  This is a clear sign that
> > the code needs to be rewritten.
> Ok, is that only for libfetch or for all of kernel (just for future
> reference).

Not sure what you mean; libfetch is not part of the kernel, and deep
nesting is almost always a symptom of poor structure or insufficient
modularization.

> Thanks for the detailed explanation. So do you think you could fix
> these style issues yourself, or should I give it a shot (I'm certain I
> will miss *some* of those issues but it will definitely get better).

I could fix your mistakes, but then you wouldn't learn from them :)

Contact me off-list when you have a new patch.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no