From owner-svn-src-all@freebsd.org Mon Sep 12 08:47:37 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37CAFBD70C6; Mon, 12 Sep 2016 08:47:37 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-vk0-x233.google.com (mail-vk0-x233.google.com [IPv6:2607:f8b0:400c:c05::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E2553DF6; Mon, 12 Sep 2016 08:47:36 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-vk0-x233.google.com with SMTP id v189so124108887vkv.1; Mon, 12 Sep 2016 01:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=oO1erJfWbLPFbUnt8lRGQ+7RUkywAShFNvhl2QGog40=; b=QQc4LgUJfqOiDSJIrThM0zfrnjJQ2VP9bGrWKnsFlKz0Mn/37JOub3MSS404VDsD38 PLB71hVTdiy8eSHG9RLLaIr0MJVH/5BAgfxfgJgK6YfcJyCZNcX3sUknY30SEuKwkK4Q tDn2L4yRz5fNHeWXmTBI8h/mh9f35OP62nJ1uxgoFwqPaWP6DQrjS12oZadDT5S1GCwu Dq3zJw8m1fLAXm+aVhRX1N6EkIcy3V4ziHy6720Qs7MhweOg4trXAkGHwOkR8KL3wUbX HKzMtanbUIcmF9Nwm++9N+n8zsLxA7uX+fl6p0A43MEfABpvgfn0P3VYKrxCu8BS4JNH Kthw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=oO1erJfWbLPFbUnt8lRGQ+7RUkywAShFNvhl2QGog40=; b=Udwt8y1+svtLhPDpgo1/tJHCEUXhyZ53zuwugPreA9171SEUnU7t8wNYYseC/xTHPw mMXqPtPeLRHRxAd3XkDAPcces5x/f3SpROgxppFpSKi0MP//nNkmSU434gFLg6DJrFn7 ImmFaFaLBS89aToyZSMC2DKktX/9MW3IBC6lCJJv4fvwEAihETWnNRwhalRZN641BjuQ BgQqXMgWhVN1lGuio/QDtKe87kKWwOe3uQh25B0xPzn81WgxftNxFeyS7UGDSAZQH4Va 80OiB62Hvepd2MOChfoCsn1GWXrhTtv7I7x++PfZJZ/6X+LN0WtPzC0uHYKPvXlVA0JP 2eng== X-Gm-Message-State: AE9vXwNQ2NySmCep/kyVMjF8NbzS5kGEMomseQbvsxaBF09MTJqsPlVallgNcHS7YDKMHSMQS6giiN29sswwfw== X-Received: by 10.31.244.207 with SMTP id s198mr6246007vkh.126.1473670056057; Mon, 12 Sep 2016 01:47:36 -0700 (PDT) MIME-Version: 1.0 Sender: sepherosa@gmail.com Received: by 10.176.69.228 with HTTP; Mon, 12 Sep 2016 01:47:35 -0700 (PDT) In-Reply-To: References: <201609120457.u8C4vw9S052665@repo.freebsd.org> <20160912083228.GW38409@kib.kiev.ua> From: Sepherosa Ziehau Date: Mon, 12 Sep 2016 16:47:35 +0800 X-Google-Sender-Auth: GF5awTCM-ZUBoReObjUGvtRYeU0 Message-ID: Subject: Re: svn commit: r305722 - head/sys/x86/x86 To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2016 08:47:37 -0000 On Mon, Sep 12, 2016 at 4:39 PM, Sepherosa Ziehau wrote: > On Mon, Sep 12, 2016 at 4:32 PM, Konstantin Belousov > wrote: >> On Mon, Sep 12, 2016 at 04:57:58AM +0000, Sepherosa Ziehau wrote: >>> Author: sephe >>> Date: Mon Sep 12 04:57:58 2016 >>> New Revision: 305722 >>> URL: https://svnweb.freebsd.org/changeset/base/305722 >>> >>> Log: >>> x86: Use sx lock for interrupt sources. >>> >>> - Certain pic_assign_cpu, e.g. msi_assign_cpu can have quite a long >>> call chain. For msi_assign_cpu, mutex makes complex PCI bridge >>> drivers more tricky, e.g. sleep can note be called, etc, it will >>> be pretty tricky for upcoming Hyper-V PCI bridge driver for PCI >>> pass-through. >> >>> - It is not used on any hot code path nor non-sleepable context, so >>> sx should have the same effect as mutex. >> Did you tested ACPI_DMAR interrupt remapping mode with your patch and >> witness enabled ? > > Nope, I am about to try it now. BTW, I just checked the code for > ACPI_DMAR, I didn't see anything obviously w/ the lock type change > though. I didn't notice anything wrong w/ options ACPI_DMAR+WITNESS+INVARIANTS. If you saw anything wrong, please let me know. Thanks, sephe -- Tomorrow Will Never Die