From owner-svn-src-all@freebsd.org Fri Dec 14 18:25:15 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84AD1133E9E4; Fri, 14 Dec 2018 18:25:15 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 292FA8A89A; Fri, 14 Dec 2018 18:25:15 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (static-71-168-218-4.cmdnnj.fios.verizon.net [71.168.218.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jkim/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 0A5091B0F3; Fri, 14 Dec 2018 18:25:15 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Subject: Re: svn commit: r342057 - head/crypto/openssl/crypto/engine To: koobs@FreeBSD.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201812140106.wBE16Zgr058499@repo.freebsd.org> <216fb35b-28d1-faaa-d115-1f4a601212f0@FreeBSD.org> From: Jung-uk Kim Openpgp: preference=signencrypt Autocrypt: addr=jkim@FreeBSD.org; prefer-encrypt=mutual; keydata= mQENBFJBztUBCAChqNyGqmFuNo0U7MBzsD+q/G6Cv0l7LGVrOAsgh34M8wIWhD+tztDWMVfn AhxNDd0ceCj2bYOe67sTQxAScEcbt2FfvPOLp9MEXb9qohZj172Gwkk7dnhOhZZKhVGVZKM4 NcsuBDUzgf4f3Vdzj4wg6WlqplnTZo8lPE4hZWvZHoFIyunPTJWenybeV1xnxK7JkUdSvQR0 fA59RfTTECMwTrSEfYGUnxIDBraxJ7Ecs/0hGQ7sljIj8WBvlRDU5fU1xfF35aw56T8POQRq F4E6RVJW3YGuTpSwgtGZOTfygcLRhAiq3dFC3JNLaTVTpM8PjOinJyt9AU6RoITGOKwDABEB AAG0Hkp1bmctdWsgS2ltIDxqa2ltQEZyZWVCU0Qub3JnPokBPQQTAQoAJwUCUkHO1QIbAwUJ E0/POwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRB8n5Ym/NvxRqyzB/wL7QtsIpeGfGIA ZPMtgXMucM3NWzomyQMln2j2efUkDKthzh9jBxgF53TjOr7imwIt0PT2k1bqctPrq5IRqnu9 mGroqaCLE3LG2/E3jEaao4k9PO6efwlioyivUo5NrqIQOQ4k3EAXw7d2y0Dk1VpTgdMrnUAB hj7lGlLqS4ydcrf24DdbCRGdEQwqd9DBeBgbWynxAJMgbZBhYVEyIHuQKkJ8qY0ibIPXXuF0 KYDeH0qUHtWV2K3srNyPtymUkBQD84Pl1GWRYx05XdUHDmnX0JV3lg0BfYJZgZv0ehPQrMfY Fd9abTkf9FHQYz1JtsC8wUuRgqElRd6+YAGf8Tt9uQENBFJBztUBCADLtSrP44El2VoJmH14 OFrlOgxzZnbn+Y/Gf1k12mJBiR+A+pBeRLD50p7AiTrjHRxO3cHcl9Dh0uf1VSbXgp8Or0ye iP/86fZPd4k5HXNmDTLL0HecPE08SCqGZ0W8vllQrokB1QxxRUB+fFMPJyMCjDAZ7P9fFTOS dTw1bJSTtOD8Sx8MpZUa9ti06bXFlVYDlaqSdgk181SSx+ZbSKkQR8CIMARlHwiLsa3Z9q9O EJr20HPyxe0AlTvwvFndH61hg7ds63eRvglwRnNON28VXO/lvKXq7Br/CiiyhFdKfINIx2Z5 htYq22tgGTW7mBURbIKoECFBTX9Lv6BXz6w9ABEBAAGJASUEGAEKAA8FAlJBztUCGwwFCRNP zzsACgkQfJ+WJvzb8UZcJQf+IsTCxUEqY7W/pT84sMg5/QD3s6ufTRncvq14fEOxCNq1Rf4Q 9P+tOFa8GZfKDGB2BFGIrW7uT5mlmKdK1vO6ZIA930y5kUsnCmBUEBJkE2ciSQk01aB/1o62 Q3Gk/F6BwtNY9OXiqF7AcAo+K/BMIaqb26QKeh+IIgK1NN9dQiq3ByTbl4zpGZa6MmsnnRTu mzGKt2nkz7vBzH6+hZp1OzGZikgjjhYWVFoJo1dvf/rv4obs0ZJEqFPQs/1Qa1dbkKBv6odB XJpPH0ssOluTY24d1XxTiKTwmWvHeQkOKRAIfD7VTtF4TesoZYkf7hsh3e3VwXhptSLFnEOi WwYofg== Message-ID: <3f9a0289-4539-368f-0ddd-b9ca9be2ac69@FreeBSD.org> Date: Fri, 14 Dec 2018 13:25:06 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <216fb35b-28d1-faaa-d115-1f4a601212f0@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XhGWniLjE0DGInk1VEfa2XZqOHrFDd7TG" X-Rspamd-Queue-Id: 292FA8A89A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.99)[-0.988,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-0.998,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 18:25:15 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XhGWniLjE0DGInk1VEfa2XZqOHrFDd7TG Content-Type: multipart/mixed; boundary="9UFlAsadM5x6cqJVyckHyAvuhzcdr5230"; protected-headers="v1" From: Jung-uk Kim To: koobs@FreeBSD.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <3f9a0289-4539-368f-0ddd-b9ca9be2ac69@FreeBSD.org> Subject: Re: svn commit: r342057 - head/crypto/openssl/crypto/engine References: <201812140106.wBE16Zgr058499@repo.freebsd.org> <216fb35b-28d1-faaa-d115-1f4a601212f0@FreeBSD.org> In-Reply-To: <216fb35b-28d1-faaa-d115-1f4a601212f0@FreeBSD.org> --9UFlAsadM5x6cqJVyckHyAvuhzcdr5230 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 18. 12. 13., Kubilay Kocak wrote: > On 14/12/2018 12:06 pm, Jung-uk Kim wrote: >> Author: jkim >> Date: Fri Dec 14 01:06:34 2018 >> New Revision: 342057 >> URL: https://svnweb.freebsd.org/changeset/base/342057 >> >> Log: >> =C2=A0=C2=A0 Do not complain when /dev/crypto does not exist. >> =C2=A0=C2=A0 =C2=A0=C2=A0 Now the new devcrypto engine is enabled sinc= e r342009, many >> users started >> =C2=A0=C2=A0 seeing "Could not open /dev/crypto: No such file or direc= tory".=C2=A0 >> Disable >> =C2=A0=C2=A0 the annoying error message as it is not very useful anywa= y. >> =C2=A0=C2=A0 =C2=A0=C2=A0 Note the patch was submitted upstream. >> =C2=A0=C2=A0 =C2=A0=C2=A0 https://github.com/openssl/openssl/pull/7896= >> >> Modified: >> =C2=A0=C2=A0 head/crypto/openssl/crypto/engine/eng_devcrypto.c >> >> Modified: head/crypto/openssl/crypto/engine/eng_devcrypto.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> >> --- head/crypto/openssl/crypto/engine/eng_devcrypto.c=C2=A0=C2=A0=C2=A0= Fri Dec 14 >> 00:40:38 2018=C2=A0=C2=A0=C2=A0 (r342056) >> +++ head/crypto/openssl/crypto/engine/eng_devcrypto.c=C2=A0=C2=A0=C2=A0= Fri Dec 14 >> 01:06:34 2018=C2=A0=C2=A0=C2=A0 (r342057) >> @@ -24,6 +24,8 @@ >> =C2=A0 =C2=A0 #include "internal/engine.h" >> =C2=A0 +/* #define ENGINE_DEVCRYPTO_DEBUG */ >> + >> =C2=A0 #ifdef CRYPTO_ALGORITHM_MIN >> =C2=A0 # define CHECK_BSD_STYLE_MACROS >> =C2=A0 #endif >> @@ -615,6 +617,9 @@ void engine_load_devcrypto_int() >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ENGINE *e =3D NULL; >> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ((cfd =3D open("/dev/crypto",= O_RDWR, 0)) < 0) { >> +#ifndef ENGINE_DEVCRYPTO_DEBUG >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (errno !=3D ENOENT) >> +#endif >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fprintf(stderr,= "Could not open /dev/crypto: %s\n", >> strerror(errno)); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >=20 > How trivially could devcrypto_debug=C2=A0 be modified to be a runtime > configuration (say sysctl) setting? This file came from OpenSSL and we will not implement any FreeBSD-specific code like that. Jung-uk Kim --9UFlAsadM5x6cqJVyckHyAvuhzcdr5230-- --XhGWniLjE0DGInk1VEfa2XZqOHrFDd7TG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAlwT9YoACgkQfJ+WJvzb 8UY/fAf/dTgaLXh5IFr1c2gsrDikLb141+D76BZRXtOMMJ9JyYc6gLhasQmOD/0H pdIFAIuNRlAAREzp9qT2b9MVglk9huvUNZ8a/vHOpQ2+JQKrnb5pjKJIn0u3ZQze nKQKN0vUKv/r1ZR4iH7I/36WRUDyz2LtfTct96CZU3O99GQZNsutikjqaufPKJ76 lb0P/bZGOgZuNMGuw4g5vThZfKJw7oRb0qKuu0xzEgrGSmk8cC99PMU3tpojw2Je iKQv0zZwD+nYKerPkAum4zl8oUsOZACAQBEKrQSEVuDo00NP7SNOPB9rVK4PbyS6 HVQct6geW/lqJ9o/DU5fUXotHkZQrA== =Ponw -----END PGP SIGNATURE----- --XhGWniLjE0DGInk1VEfa2XZqOHrFDd7TG--