Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Jan 2015 08:58:57 -0800
From:      Garrett Cooper <yaneurabeya@gmail.com>
To:        Will Andrews <will@FreeBSD.org>
Cc:        "svn-src-projects@freebsd.org" <svn-src-projects@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r277876 - in projects/zfsd/head/tests/sys/cddl/zfs/tests: cli_root/zpool_upgrade zil
Message-ID:  <2519DB92-D2AD-48BD-96AE-101168E9C163@gmail.com>
In-Reply-To: <201501291423.t0TENWOO048247@svn.freebsd.org>
References:  <201501291423.t0TENWOO048247@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

> On Jan 29, 2015, at 06:23, Will Andrews <will@FreeBSD.org> wrote:
>=20
> Author: will
> Date: Thu Jan 29 14:23:31 2015
> New Revision: 277876
> URL: https://svnweb.freebsd.org/changeset/base/277876
>=20
> Log:
>  Preemptively fail more tests that cause panics.
>=20
> Modified:
>  projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zpool_upgrade/zpool_=
upgrade_test.sh
>  projects/zfsd/head/tests/sys/cddl/zfs/tests/zil/zil_test.sh
>=20
> Modified: projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zpool_upgra=
de/zpool_upgrade_test.sh
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
> --- projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zpool_upgrade/zpo=
ol_upgrade_test.sh    Thu Jan 29 09:13:34 2015    (r277875)
> +++ projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zpool_upgrade/zpo=
ol_upgrade_test.sh    Thu Jan 29 14:23:31 2015    (r277876)
> @@ -219,6 +219,7 @@ zpool_upgrade_007_pos_head()
> }
> zpool_upgrade_007_pos_body()
> {
> +    atf_fail "This test causes a panic on FreeBSD"
>    export TESTCASE_ID=3D$(echo $(atf_get ident) | cksum -o 2 | cut -f 1 -d=
 " ")
>    . $(atf_get_srcdir)/../../../include/default.cfg
>    . $(atf_get_srcdir)/zpool_upgrade.kshlib
>=20
> Modified: projects/zfsd/head/tests/sys/cddl/zfs/tests/zil/zil_test.sh
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
> --- projects/zfsd/head/tests/sys/cddl/zfs/tests/zil/zil_test.sh    Thu Jan=
 29 09:13:34 2015    (r277875)
> +++ projects/zfsd/head/tests/sys/cddl/zfs/tests/zil/zil_test.sh    Thu Jan=
 29 14:23:31 2015    (r277876)
> @@ -33,6 +33,7 @@ zil_001_pos_head()
> }
> zil_001_pos_body()
> {
> +    atf_fail "This test causes a panic on FreeBSD"
>    export TESTCASE_ID=3D$(echo $(atf_get ident) | cksum -o 2 | cut -f 1 -d=
 " ")
>    . $(atf_get_srcdir)/../../include/default.cfg
>    . $(atf_get_srcdir)/zil.kshlib

Hi Will,
    Please use atf_skip instead of atf_fail so the issues don't count as fai=
lures. If you have bug numbers for the issues that would be nice too in the e=
rror messages.
Thanks!=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2519DB92-D2AD-48BD-96AE-101168E9C163>