From nobody Wed Feb 1 07:33:35 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P6DDm3drXz3cQvY for ; Wed, 1 Feb 2023 07:33:44 +0000 (UTC) (envelope-from Stephane.ROCHOY@stormshield.eu) Received: from mail.stormshield.eu (mail.stormshield.eu [91.212.116.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ictdccexch001.one.local", Issuer "Stormshield Servers CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P6DDm1CRfz3Gxc; Wed, 1 Feb 2023 07:33:44 +0000 (UTC) (envelope-from Stephane.ROCHOY@stormshield.eu) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; d=stormshield.eu; s=signer; c=simple/simple; t=1675236815; h=from:subject:to:date:message-id; bh=lVvUFKCdCGxwn1PM4zNS+C+qyzXpZiaBc9SzMWXSH34=; b=XjAH4qY0JtTJcoLIhRXR6MGWWfCKZvO0T52iCzLeFfdj9VBH5ja38f6kwLZcPLnwRkRv8ylMLBE VyJX1tkxbLJFYKSFfg4GScdcXmoMo2ZwN9ewxvNak5UZkOnADIAAlA+XT6jNDXf6H15ptVGGiEYPK FvRTeoCAIUQyZYDJScP9Z/Ax3KgZk9H4S58QbjEUO/5Oeec9+yy4Zh0cvSkEKaxppkWKaBZeGR9Tl fXe1vbPkWBdXTRp4LxzvgeyZB2N5hgEMNKInDNb3d6IptlmHZlo07jV7r5oV/9RbEre7ai1CwSX9U 03IXdCPxZtOV9UVwXMRI0fDMRlEymeHFMrSA== Received: from cthulhu.stephaner.labo.int (10.2.16.1) by ICTDCCEXCH001.one.local (10.180.4.1) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.21; Wed, 1 Feb 2023 08:33:35 +0100 Received: by cthulhu.stephaner.labo.int (Postfix, from userid 1001) id 4AD231FDC9; Wed, 1 Feb 2023 08:33:35 +0100 (CET) References: <202301300254.30U2sm0k061914@dell.no.berklix.net> <97020cad-f913-2985-2093-e4c23bf671e3@antonovs.family> <86357sxsly.fsf@cthulhu.stephaner.labo.int> <35e07b16-e635-a88c-f10b-cde0df05140b@freebsd.org> <86zg9zw0fz.fsf@cthulhu.stephaner.labo.int> User-agent: mu4e 1.2.0; emacs 27.1 From: Stephane Rochoy To: Mitchell Horne CC: Stephane Rochoy , , User Ngor , Warner Losh Subject: Re: Tooling Integration and Developer Experience In-Reply-To: Date: Wed, 1 Feb 2023 08:33:35 +0100 Message-ID: <86y1phx2k0.fsf@cthulhu.stephaner.labo.int> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.2.16.1] X-ClientProxiedBy: ICTDCCEXCH001.one.local (10.180.4.1) To ICTDCCEXCH001.one.local (10.180.4.1) X-Rspamd-Queue-Id: 4P6DDm1CRfz3Gxc X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:49068, ipnet:91.212.116.0/24, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Mitchell Horne writes: > On 1/31/23 04:52, Stephane Rochoy wrote: >> Mitchell Horne writes: >> >>> [Src] Needs Reviewer >>> https://reviews.freebsd.org/differential/query/65AoyPFlIhdE/ >> What is the purpose of the "Contributor Reviews (base)" >> project/group? >> Regards, >> -- St=C3=A9phane Rochoy >> O: Stormshield >> > > It is a group ("Project") that anyone can join to receive=20 > notifications whenever > the group is tagged. Groups can be added as a reviewer on a=20 > revision, for > example. > > There is a Herald rule to automatically add this Contributor=20 > Reviews group as a > subscriber to any src revisions that have no reviewers=20 > specified. > > This makes it an imperfect search criteria for "reviews which=20 > are accepted but > not authored by a FreeBSD committer". I guess the committers group was not used to let developers choose to participate or not to the "Needs Reviewer" effort. Correct? As a side note, I was surprised to see we can't query reviews from users not being in a given group, i.e., "Responsible Users" not in "Contributor Reviews (base)" would have been more straightforward. (The Project application allow advanced queries via not() and any() functions). Regards, -- St=C3=A9phane Rochoy O: Stormshield